Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the height for the signup input fields and fix web accessibility issues #1928

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Set the height for the signup input fields and fix web accessibility issues #1928

merged 7 commits into from
Dec 9, 2024

Conversation

eunjuhuss
Copy link
Contributor

Description:

  • Set the input height to prevent changes when an error occurs under the input
  • Fix a few web accessibility issues. Fields must be inside a form, and labels should be associated with the inputs
  • Remove fieldsets outside the

For reviewer:

  • Read the above description
  • Reviewed the code changes
  • Navigate to the branch (pulled the latest version)
  • Run the code and been able to execute the expected function
  • Check any styling on both desktop and mobile sizes

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cartja cartja merged commit 250f5cd into main Dec 9, 2024
15 checks passed
@cartja cartja deleted the eunju-set-height-form branch December 9, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjuhuss @cartja