Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace error page animations by static images #1057

Closed
baszoetekouw opened this issue Nov 10, 2023 · 6 comments
Closed

Replace error page animations by static images #1057

baszoetekouw opened this issue Nov 10, 2023 · 6 comments
Labels
UI User interface only stories
Milestone

Comments

@baszoetekouw
Copy link
Member

baszoetekouw commented Nov 10, 2023

The animated error pages currently use the lottie-player module, which is quite large and can be run with a strict CSP (see #764).

Therefore, we should replace the animated pages by a nice static images.

The following pages should be fixed:

@FlorisFokkinga could you propose what these pages should look like?

@baszoetekouw
Copy link
Member Author

Is /dead-end even used anymore? What is dat supposed to do?

@oharsta
Copy link
Collaborator

oharsta commented Nov 10, 2023

See also e0de2fd. I have put the images in the original lotties folder to find them easily. Once the final images are picked, we can move them.

@FlorisFokkinga
Copy link
Contributor

It is permitted to use animated SVG files for this.

@FlorisFokkinga FlorisFokkinga moved this from New to Todo in SRAM development Nov 17, 2023
@FlorisFokkinga FlorisFokkinga added the UI User interface only stories label Nov 17, 2023
@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Nov 24, 2023

I've spent 15 minutes searching for OK looking CSS animated SVGs, didn't find any.

@FlorisFokkinga
Copy link
Contributor

Please (re)center the 404 page: https://test.sram.surf.nl/anythinghere

oharsta added a commit that referenced this issue Nov 24, 2023
@oharsta
Copy link
Collaborator

oharsta commented Nov 24, 2023

Re-centered 404 in 81e7420

@oharsta oharsta closed this as completed Dec 4, 2023
@oharsta oharsta moved this from Todo to To be tested in SRAM development Dec 4, 2023
@baszoetekouw baszoetekouw added this to the v29 milestone Dec 5, 2023
@FlorisFokkinga FlorisFokkinga moved this from To be tested to Being tested in SRAM development Dec 6, 2023
@FlorisFokkinga FlorisFokkinga moved this from Being tested to To be deployed in SRAM development Dec 6, 2023
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface only stories
Projects
Archived in project
Development

No branches or pull requests

3 participants