Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An org manager scoped on one ore more units, should only be able to see and edit COs of those units #1060

Closed
FlorisFokkinga opened this issue Nov 13, 2023 · 3 comments
Closed

An org manager scoped on one ore more units, should only be able to see and edit COs of those units #1060

FlorisFokkinga opened this issue Nov 13, 2023 · 3 comments
Labels
bug Something isn't working
Milestone
v28

Comments

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Nov 13, 2023 •
edited
Loading

Reproduction

Org manager assigned to unit 'Faculty'
image

All COs (platform admin view)
image

  • Expected view for org manager: only the CO for unit 'Faculty' 'Monitoring CO numero 1'
  • Observed view: only the CO without a unit label 'UUC Teachers'

image

Reproduction, continued

  • Assigned unit 'Faculty' to the CO 'UUC Teachers'
  • Expected and observed view: only the CO with the unit label: 'UUC Teachers'

image

Expected behaviour

  • An organisation manager for unit A can only view/edit COs that are assigned to unit A (not exclusively).
  • An organisation manager for unit A and unit B can only view/edit COs that are (at least) assigned to unit A an/or unit B (not exclusively).
@FlorisFokkinga FlorisFokkinga added the bug Something isn't working label Nov 13, 2023
@FlorisFokkinga FlorisFokkinga added this to the v28 milestone Nov 13, 2023
@FlorisFokkinga FlorisFokkinga moved this from New to Todo in SRAM development Nov 13, 2023
@FlorisFokkinga FlorisFokkinga mentioned this issue Nov 13, 2023
Closed
oharsta added a commit that referenced this issue Nov 14, 2023
@oharsta
Fixes #1064 #1063 #1060
9d20f9d
@oharsta oharsta moved this from Todo to In progress in SRAM development Nov 14, 2023
@oharsta oharsta moved this from In progress to To be tested in SRAM development Nov 14, 2023
baszoetekouw pushed a commit that referenced this issue Nov 15, 2023
@oharsta @baszoetekouw
Fixes #1064 #1063 #1060
4e434ad
@baszoetekouw
Copy link
Member

baszoetekouw commented Nov 15, 2023 •
edited
Loading

There is stil an issue here: Org Managers can still view all COs of the Org (by visiting the direct URL), even though the CO is not shown in the table in the Org screen.
They should only be able to see the COs in their own Unit.

@baszoetekouw baszoetekouw moved this from To be tested to Todo in SRAM development Nov 15, 2023
@baszoetekouw
Copy link
Member

Rest of the story tested an is ok.

@sram-project-automation sram-project-automation bot moved this from Todo to To be tested in SRAM development Nov 15, 2023
baszoetekouw pushed a commit that referenced this issue Nov 15, 2023
@oharsta @baszoetekouw
Fixes #1060
2cde516 
The organisation manager was not granted "full" support to view the CO,
but being an Org manager was granted "lite" support to view the
collaboration details. Fix is to re-use the check if the Org
manager has access based on the units of his membership.
@baszoetekouw
Copy link
Member

now fixed.

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development Nov 15, 2023
baszoetekouw pushed a commit that referenced this issue Nov 15, 2023
@oharsta @baszoetekouw
Fixes #1064 #1063 #1060
3060534
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
SRAM development
Archived in project
Milestone
v28
Development

No branches or pull requests
3 participants
@oharsta @baszoetekouw @FlorisFokkinga