Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an organisation admin, I want to be able to have to accept or reject service requests #1070

Closed
FlorisFokkinga opened this issue Nov 16, 2023 · 1 comment
Milestone

Comments

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Nov 16, 2023

Background

Certain organisations require strict control over what services are used under their responsibility. Such an organisation needs to be able to control what services are connected to their collaborations as a condition for using SRAM.

Proposed solution

https://confluence.ia.surf.nl/display/SRAM/Diensten+goedkeuren+door+organisatie

  • When a collaboration admin wants to connect a service, a request should be sent to the org admin to approve or deny the request.
  • It should be clear for the requester, the request goes to the organisation admins.
  • If the service admin also needs to approve the connection, it goes to the service admin after approval by the org admin.

This should be configurable per organisation by platform admin. Hide the setting for the org admin if it is disabled. Obviously, disabled is the default state.

Possible future extension

https://github.com/orgs/SURFscz/projects/5/views/1?pane=issue&itemId=40041824
https://github.com/orgs/SURFscz/projects/5/views/1?pane=issue&itemId=40042006

@FlorisFokkinga FlorisFokkinga converted this from a draft issue Nov 16, 2023
@oharsta oharsta moved this from Todo to In progress in SRAM development Nov 17, 2023
oharsta added a commit that referenced this issue Nov 20, 2023
oharsta added a commit that referenced this issue Nov 21, 2023
oharsta added a commit that referenced this issue Nov 21, 2023
oharsta added a commit that referenced this issue Nov 21, 2023
@sram-project-automation sram-project-automation bot moved this from In progress to To be tested in SRAM development Nov 22, 2023
@baszoetekouw baszoetekouw added this to the v29 milestone Nov 27, 2023
@FlorisFokkinga FlorisFokkinga moved this from To be tested to Being tested in SRAM development Nov 30, 2023
@FlorisFokkinga
Copy link
Contributor Author

Works as an MVP. We might want to think about a way to provide the org admin with info about the requested service, but that can be worked around.

@FlorisFokkinga FlorisFokkinga moved this from Being tested to To be deployed in SRAM development Nov 30, 2023
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants