Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org API should return 404 instead of 403 when CO is not found in Org #1073

Closed
baszoetekouw opened this issue Nov 16, 2023 · 1 comment
Closed

Org API should return 404 instead of 403 when CO is not found in Org #1073

baszoetekouw opened this issue Nov 16, 2023 · 1 comment
Labels
API
Milestone
v29

Comments

@baszoetekouw
Copy link
Member

The Org API currently return 403 when a CO is not found (or not found in the Org). More correct would be to return 404: the CO requested was not found in the Org. Whether or not the CO exists in another Org (and thus whether this is a permission issue) is not relevant.
@baszoetekouw baszoetekouw self-assigned this Nov 16, 2023
@sram-project-automation sram-project-automation bot moved this from New to To be tested in SRAM development Nov 16, 2023
@baszoetekouw baszoetekouw added this to the v29 milestone Nov 27, 2023
baszoetekouw added a commit that referenced this issue Dec 8, 2023
@baszoetekouw
Fix error messages in Org API (closes #1073)
e19ea44 
The case where a CO was not found, and the case where a CO was found but does not belong to the correct Org should give identical error messages.
@baszoetekouw
Copy link
Member Author

tested

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development Dec 8, 2023
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
SRAM development
Archived in project
Milestone
v29
Development

No branches or pull requests
1 participant
@baszoetekouw