Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units for organisations #967

Closed
14 tasks done
FlorisFokkinga opened this issue Sep 22, 2023 · 1 comment
Closed
14 tasks done

Units for organisations #967

FlorisFokkinga opened this issue Sep 22, 2023 · 1 comment
Labels
UI User interface only stories UX-design Needs input from our UX designer
Milestone

Comments

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Sep 22, 2023

Concept

Add organisational units. These units help manage COs for organisations that want to assign specific org managers to specific groups of COs. The feature shouldn't increase complexity for organisations that don't use them. It is enabled by an org admin adding units. Before that none of it is visible to other users.

CO's are assigned to 0, 1 or more units. Org mangers that are assigned to units, can only view and edit COs that belong to one (or more) of their units. To manage which (if any) units a org manager is assigned, an edit org admin screen must be added and the invite org manager screen expanded.

  • Create Unit class and many-to-many relationships with OrganisationInvitation, CollaborationRequest, Collaboration and OrganisationMembership and one-to-many relationship with Organisation
  • Translations
  • Add Units component to create / edit Organisation
  • Add Units read-only component to create / edit Collaboration
  • Add Units read-only component to create / edit CollaborationRequest
  • Add Units read-only component to invite OrganisationMembership
  • API changes: all Unit relationships need to be saved on create / update in models
  • Add column with units to CO's overview. To make room remove the 'invites' column from all tables with COs
  • Check for delete units if they are in use (server side endpoint)
  • Display the unit(s) in the CO header
  • Only expose CO's to ORG managers that have either no Units or all Units belong to the ORG membership
  • Ensure CO managers can not fetch, update or delete CO's they don't have access to
  • CO's to be managed component for re-use in edit manager-role and org. invitation
  • OrganisationMembership row is clickable (if user is admin and row is manager and organisation has units) and show details with Units component

Design

Edit organisation

Manage unit labels
image

New CO

  • Create CO by org admin or org manager: can choose unit
  • Request/create CO by user: can suggest unit
    Image

CO tab for organisation

Add column with units. To make room remove the 'invites' column from all tables with COs.
image (2)

CO detail page

Display the unit
image (3)

Invite new org manager

Select 0, 1 or multiple units
image (4)

Edit org manager details

image (5)

@FlorisFokkinga FlorisFokkinga converted this from a draft issue Sep 22, 2023
@FlorisFokkinga FlorisFokkinga self-assigned this Sep 22, 2023
@FlorisFokkinga FlorisFokkinga added the UX-design Needs input from our UX designer label Sep 22, 2023
@FlorisFokkinga FlorisFokkinga moved this from Todo to In progress in SRAM development Sep 25, 2023
@FlorisFokkinga FlorisFokkinga moved this from In progress to New in SRAM development Sep 25, 2023
@FlorisFokkinga FlorisFokkinga moved this from New to Todo in SRAM development Oct 18, 2023
@FlorisFokkinga FlorisFokkinga changed the title Departments/projects for organisations Units for organisations Oct 19, 2023
@FlorisFokkinga FlorisFokkinga added the UI User interface only stories label Oct 19, 2023
@oharsta oharsta moved this from Todo to In progress in SRAM development Oct 20, 2023
oharsta added a commit that referenced this issue Oct 20, 2023
oharsta added a commit that referenced this issue Oct 20, 2023
@FlorisFokkinga FlorisFokkinga removed their assignment Oct 23, 2023
oharsta added a commit that referenced this issue Oct 23, 2023
oharsta added a commit that referenced this issue Oct 24, 2023
oharsta added a commit that referenced this issue Oct 25, 2023
oharsta added a commit that referenced this issue Oct 26, 2023
oharsta added a commit that referenced this issue Oct 26, 2023
@sram-project-automation sram-project-automation bot moved this from In progress to To be tested in SRAM development Oct 27, 2023
@FlorisFokkinga FlorisFokkinga self-assigned this Oct 29, 2023
@baszoetekouw baszoetekouw added this to the v28 milestone Oct 31, 2023
@baszoetekouw
Copy link
Member

looking good. Further antfucking in #1052

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development Nov 7, 2023
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface only stories UX-design Needs input from our UX designer
Projects
Archived in project
Development

No branches or pull requests

3 participants