Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sramInactiveDays not stored if it is 0 #134

Closed
baszoetekouw opened this issue Jun 19, 2024 · 1 comment · Fixed by #138
Closed

sramInactiveDays not stored if it is 0 #134

baszoetekouw opened this issue Jun 19, 2024 · 1 comment · Fixed by #138
Milestone

Comments

@baszoetekouw
Copy link
Member

baszoetekouw commented Jun 19, 2024

This filter interferes: https://github.com/SURFscz/plsc/blob/main/plsc_ordered.py#L102-L103
It filters away all False values, of which 0 is one.

What is the reason for this filter? Would filtering only None value suffice?
i.e.

for key, val in record.items():
    record[key] = [r for r in record[key] if r is not None]
@baszoetekouw baszoetekouw changed the title sramInactiveDays not stored is it is 0 sramInactiveDays not stored if it is 0 Jun 19, 2024
@baszoetekouw baszoetekouw moved this from New to Todo in SRAM development Sep 19, 2024
@mrvanes mrvanes linked a pull request Sep 24, 2024 that will close this issue
@baszoetekouw baszoetekouw added this to the v37 milestone Sep 30, 2024
@logan-life logan-life modified the milestones: v37, v38 Oct 9, 2024
@baszoetekouw baszoetekouw modified the milestones: v37, v38 Oct 11, 2024
@baszoetekouw baszoetekouw linked a pull request Oct 11, 2024 that will close this issue
@baszoetekouw
Copy link
Member Author

Works: Image

@baszoetekouw baszoetekouw moved this from To be tested to To be deployed in SRAM development Nov 13, 2024
@sram-deploy-tools-automation sram-deploy-tools-automation bot moved this from To be deployed to Done in SRAM development Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants