Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce accumulating statistic in time-series DB #325

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

asmorodskyi
Copy link
Collaborator

@asmorodskyi asmorodskyi commented Oct 23, 2023

Idea is to start gathering statistic about amount of entities existing in every account at every point of time . This will allow detect different kind of anomalies in testing pipelines ( e.g. bugs in scheduling , bugs in cleanup etc. )
This PR just introduce functionality which allow to achieve this in future PRs we will start using it in EVERY query for EVERY cloud provider

@asmorodskyi asmorodskyi marked this pull request as draft October 23, 2023 12:43
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (eca9f33) 79.06% compared to head (5e0eeef) 79.11%.
Report is 5 commits behind head on master.

Files Patch % Lines
ocw/lib/influx.py 76.20% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   79.06%   79.11%   +0.05%     
==========================================
  Files          21       22       +1     
  Lines        1614     1656      +42     
==========================================
+ Hits         1276     1310      +34     
- Misses        338      346       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmorodskyi asmorodskyi force-pushed the grafana branch 3 times, most recently from dbf3d63 to 065ff45 Compare October 23, 2023 18:04
@asmorodskyi asmorodskyi force-pushed the grafana branch 2 times, most recently from d07fc7f to a7f476d Compare November 2, 2023 21:01
tests/test_influx.py Outdated Show resolved Hide resolved
@asmorodskyi asmorodskyi force-pushed the grafana branch 2 times, most recently from b6dbc73 to f9ad91d Compare November 3, 2023 12:20
@asmorodskyi asmorodskyi marked this pull request as ready for review November 3, 2023 12:20
@asmorodskyi asmorodskyi force-pushed the grafana branch 2 times, most recently from d026e57 to 5f4ba7f Compare November 14, 2023 11:53
ocw/lib/influx.py Outdated Show resolved Hide resolved
ocw/lib/azure.py Outdated Show resolved Hide resolved
@asmorodskyi asmorodskyi marked this pull request as draft December 1, 2023 14:24
 Idea is to start gathering statistic about amount of entities
existing in every account at every point of time.
 This will allow detect different kind of anomalies in
testing pipelines (e.g. bugs in scheduling , bugs in cleanup etc.)
 This PR just introduce functionality which allow to achieve
this in future PRs we will start using it in EVERY query
for EVERY cloud provider.
@asmorodskyi
Copy link
Collaborator Author

@ricardobranco777 - please check latest version , is that what you suggested ?

@ricardobranco777
Copy link
Collaborator

@ricardobranco777 - please check latest version , is that what you suggested ?

This is pure beauty!!!

Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel more comfortable now merging this as we're adding the new functionality without modifying existing code.

Nice work!

@asmorodskyi asmorodskyi marked this pull request as ready for review December 4, 2023 09:25
@asmorodskyi asmorodskyi merged commit 2c2dc9f into SUSE:master Dec 4, 2023
9 checks passed
@asmorodskyi asmorodskyi deleted the grafana branch February 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants