diff --git a/app/controllers/api/connect/v3/systems/systems_controller.rb b/app/controllers/api/connect/v3/systems/systems_controller.rb index 08c60f105..f8f3b8c92 100644 --- a/app/controllers/api/connect/v3/systems/systems_controller.rb +++ b/app/controllers/api/connect/v3/systems/systems_controller.rb @@ -3,6 +3,22 @@ class Api::Connect::V3::Systems::SystemsController < Api::Connect::BaseControlle before_action :authenticate_system def update + if params[:online_at].present? + params[:online_at].each do |online_at| + dthours = online_at.split(':') + if dthours.count == 2 + begin + @system_uptime = SystemUptime.create!(system_id: @system.id, online_at_day: dthours[0], online_at_hours: dthours[1]) + logger.debug(N_("Added uptime information for system '%s'") % @system.id) + rescue ActiveRecord::RecordNotUnique + logger.debug(N_("Uptime information existing for system '%s'") % @system.id) + end + else + logger.error(N_("Uptime data is malformed '%s'") % online_at) + end + end + end + @system.hostname = params[:hostname] # Since the payload is handled by rails all values are converted to string diff --git a/app/models/system.rb b/app/models/system.rb index 1e10bbc4c..0883f7de0 100644 --- a/app/models/system.rb +++ b/app/models/system.rb @@ -6,6 +6,7 @@ class System < ApplicationRecord has_many :services, through: :activations has_many :repositories, -> { distinct }, through: :services has_many :products, -> { distinct }, through: :services + has_many :system_uptimes, dependent: :destroy validates :system_token, uniqueness: { scope: %i[login password], case_sensitive: false } diff --git a/app/models/system_uptime.rb b/app/models/system_uptime.rb new file mode 100644 index 000000000..f6bf1087b --- /dev/null +++ b/app/models/system_uptime.rb @@ -0,0 +1,7 @@ +class SystemUptime < ApplicationRecord + belongs_to :system + + validates :system_id, presence: true + validates :online_at_day, presence: true + validates :online_at_hours, presence: true +end diff --git a/db/migrate/20240111200053_create_system_uptimes.rb b/db/migrate/20240111200053_create_system_uptimes.rb new file mode 100644 index 000000000..9c7b001f0 --- /dev/null +++ b/db/migrate/20240111200053_create_system_uptimes.rb @@ -0,0 +1,18 @@ +class CreateSystemUptimes < ActiveRecord::Migration[6.1] + def change + safety_assured do + create_table :system_uptimes, id: false do |t| + t.bigint :system_id, null: false + t.date :online_at_day, null: false + t.column :online_at_hours, 'binary(24)', null: false + t.timestamps + end + + commit_db_transaction + + add_index :system_uptimes, %i[system_id online_at_day online_at_hours], unique: true, name: 'id_online_day_hours' + + add_foreign_key :system_uptimes, :systems, column: :system_id, validate: false + end + end +end diff --git a/lib/rmt.rb b/lib/rmt.rb index c763386a7..ec7b4497d 100644 --- a/lib/rmt.rb +++ b/lib/rmt.rb @@ -1,5 +1,5 @@ module RMT - VERSION ||= '2.15'.freeze + VERSION ||= '2.16'.freeze DEFAULT_USER = '_rmt'.freeze DEFAULT_GROUP = 'nginx'.freeze diff --git a/lib/tasks/system_uptimes.rake b/lib/tasks/system_uptimes.rake new file mode 100644 index 000000000..3a7231130 --- /dev/null +++ b/lib/tasks/system_uptimes.rake @@ -0,0 +1,8 @@ +namespace :db do + namespace :maintenance do + desc 'Delete all uptime tracking data which are older than 90 days' + task cleanup_uptime_tracking: :environment do + SystemUptime.where("online_at_day < '#{2.days.ago}'").delete_all + end + end +end diff --git a/package/files/systemd/rmt-uptime-cleanup.service b/package/files/systemd/rmt-uptime-cleanup.service new file mode 100644 index 000000000..cce384e23 --- /dev/null +++ b/package/files/systemd/rmt-uptime-cleanup.service @@ -0,0 +1,12 @@ +[Unit] +Description=RMT uptime cleanup service +Requires=mysql.service +Wants=rmt-uptime-cleanup.timer + +[Service] +Type=oneshot +WorkingDirectory=/usr/share/rmt/bin +ExecStart=bundle exec rake db:maintenance:cleanup_uptime_tracking RAILS_ENV=production + +[Install] +WantedBy=multi-user.target diff --git a/package/files/systemd/rmt-uptime-cleanup.timer b/package/files/systemd/rmt-uptime-cleanup.timer new file mode 100644 index 000000000..6dc8c930d --- /dev/null +++ b/package/files/systemd/rmt-uptime-cleanup.timer @@ -0,0 +1,10 @@ +[Unit] +Description=RMT Uptime Data cleanup timer + +[Timer] +# Run this timer every day at a randomized 24h delay. +OnCalendar=daily +RandomizedDelaySec=24h + +[Install] +WantedBy=timers.target diff --git a/package/obs/rmt-server.spec b/package/obs/rmt-server.spec index 28c84df55..e8e56f684 100644 --- a/package/obs/rmt-server.spec +++ b/package/obs/rmt-server.spec @@ -1,7 +1,7 @@ # # spec file for package rmt-server # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -30,7 +30,7 @@ %define ruby_version %{rb_default_ruby_suffix} Name: rmt-server -Version: 2.15 +Version: 2.16 Release: 0 Summary: Repository mirroring tool and registration proxy for SCC License: GPL-2.0-or-later @@ -143,6 +143,7 @@ mkdir -p %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-mirror.timer %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-sync.timer %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-systems-scc-sync.timer %{buildroot}%{_unitdir} +install -m 444 package/files/systemd/rmt-uptime-cleanup.timer %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-mirror.service %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-sync.service %{buildroot}%{_unitdir} @@ -150,6 +151,7 @@ install -m 444 package/files/systemd/rmt-server-systems-scc-sync.service %{build install -m 444 package/files/systemd/rmt-server.service %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server.target %{buildroot}%{_unitdir} install -m 444 package/files/systemd/rmt-server-migration.service %{buildroot}%{_unitdir} +install -m 444 package/files/systemd/rmt-uptime-cleanup.service %{buildroot}%{_unitdir} install -m 444 engines/registration_sharing/package/rmt-server-regsharing.service %{buildroot}%{_unitdir} install -m 444 engines/registration_sharing/package/rmt-server-regsharing.timer %{buildroot}%{_unitdir} @@ -162,6 +164,7 @@ ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-migration ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-mirror ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-sync ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-systems-scc-sync +ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-uptime-cleanup ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-regsharing ln -fs %{_sbindir}/service %{buildroot}%{_sbindir}/rcrmt-server-trim-cache @@ -268,6 +271,7 @@ chrpath -d %{buildroot}%{lib_dir}/vendor/bundle/ruby/*/extensions/*/*/mysql2-*/m %{_sbindir}/rcrmt-server-sync %{_sbindir}/rcrmt-server-mirror %{_sbindir}/rcrmt-server-systems-scc-sync +%{_sbindir}/rcrmt-uptime-cleanup %{_unitdir}/rmt-server.target %{_unitdir}/rmt-server.service %{_unitdir}/rmt-server-migration.service @@ -277,6 +281,8 @@ chrpath -d %{buildroot}%{lib_dir}/vendor/bundle/ruby/*/extensions/*/*/mysql2-*/m %{_unitdir}/rmt-server-sync.timer %{_unitdir}/rmt-server-systems-scc-sync.service %{_unitdir}/rmt-server-systems-scc-sync.timer +%{_unitdir}/rmt-uptime-cleanup.service +%{_unitdir}/rmt-uptime-cleanup.timer %dir %{_datadir}/bash-completion/ %dir %{_datadir}/bash-completion/completions/ %{_datadir}/bash-completion/completions/rmt-cli @@ -317,10 +323,10 @@ getent group %{rmt_group} >/dev/null || %{_sbindir}/groupadd -r %{rmt_group} getent passwd %{rmt_user} >/dev/null || \ %{_sbindir}/useradd -g %{rmt_group} -s /bin/false -r \ -c "user for RMT" %{rmt_user} -%service_add_pre rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service +%service_add_pre rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service rmt-uptime-cleanup.service %post -%service_add_post rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service +%service_add_post rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service rmt-uptime-cleanup.service # Run only on install if [ $1 -eq 1 ]; then @@ -353,10 +359,10 @@ if [ ! -e %{_datadir}/rmt/public/suma ]; then fi %preun -%service_del_preun rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service +%service_del_preun rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service rmt-uptime-cleanup.service %postun -%service_del_postun rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service +%service_del_postun rmt-server.target rmt-server.service rmt-server-migration.service rmt-server-mirror.service rmt-server-sync.service rmt-server-systems-scc-sync.service rmt-uptime-cleanup.service %posttrans config # Don't fail if either systemd or nginx are not running diff --git a/spec/models/system_uptime_spec.rb b/spec/models/system_uptime_spec.rb new file mode 100644 index 000000000..84d2c2f68 --- /dev/null +++ b/spec/models/system_uptime_spec.rb @@ -0,0 +1,7 @@ +require 'rails_helper' + +RSpec.describe SystemUptime, type: :model do + it { is_expected.to validate_presence_of(:system_id) } + it { is_expected.to validate_presence_of(:online_at_day) } + it { is_expected.to validate_presence_of(:online_at_hours) } +end diff --git a/spec/requests/api/connect/v3/systems/systems_controller_spec.rb b/spec/requests/api/connect/v3/systems/systems_controller_spec.rb index f029c5dff..cac33c73b 100644 --- a/spec/requests/api/connect/v3/systems/systems_controller_spec.rb +++ b/spec/requests/api/connect/v3/systems/systems_controller_spec.rb @@ -18,6 +18,8 @@ } end let(:payload) { { hostname: 'test', hwinfo: hwinfo } } + let(:systemuptime) { system.system_uptimes.first } + let(:online_hours) { ':111111111111111111111111' } describe '#update' do subject(:update_action) { put url, params: payload, headers: headers } @@ -45,6 +47,41 @@ expect(information[:cpus]).to eq('16') end end + + context 'when uptime data provided' do + let(:payload) { { hostname: 'test', hwinfo: hwinfo, online_at: [1.day.ago.to_date.to_s << online_hours] } } + + it 'inserts the uptime data in system_uptimes table' do + update_action + + expect(systemuptime.system_id).to eq(system.reload.id) + expect(systemuptime.online_at_day.to_date).to eq(1.day.ago.to_date) + expect(systemuptime.online_at_hours.to_s).to eq('111111111111111111111111') + end + end + + context 'when same uptime data added twice' do + let(:payload) { { hostname: 'test', hwinfo: hwinfo, online_at: [1.day.ago.to_date.to_s << online_hours, 1.day.ago.to_date.to_s << online_hours] } } + + it 'avoids duplication if multiple records have same data' do + update_action + + expect(system.system_uptimes.count).to eq(1) + expect(systemuptime.system_id).to eq(system.reload.id) + expect(systemuptime.online_at_day.to_date).to eq(1.day.ago.to_date) + expect(systemuptime.online_at_hours.to_s).to eq('111111111111111111111111') + end + end + + context 'when uptime data is malformed' do + let(:payload) { { hostname: 'test', hwinfo: hwinfo, online_at: [1.day.ago.to_date.to_s] } } + + it 'record is not inserted' do + update_action + + expect(system.system_uptimes.count).to eq(0) + end + end end context 'when hostname is not provided' do