Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature suggestion: Move Numbers options #758

Open
David53bcg opened this issue Dec 9, 2020 · 7 comments · May be fixed by #826
Open

Feature suggestion: Move Numbers options #758

David53bcg opened this issue Dec 9, 2020 · 7 comments · May be fixed by #826
Labels
enhancement

Comments

@David53bcg
Copy link

David53bcg commented Dec 9, 2020 •
edited
Loading

It might be helpful for study to have a couple of additional options for move numbering to show a lesser number than the full game:

  • Numbering last x moves as a fixed preference, still showing their correct numbers in the game sequence
  • Numbering next y moves from '1' anywhere in the game, as a toggle feature for both play and replay
@goodger
Copy link

goodger commented Dec 30, 2020 •
edited
Loading

I agree. Having all move numbers is too busy much of the time.

[Edited:] The current move number is shown in the scroll bar of the game tree.

@goodger
Copy link

goodger commented Jan 27, 2021

It would be very useful to automatically number the moves within variations, like on OGS.

@kevinsung
Copy link 

* Numbering next y moves from '1' anywhere in the game, as a toggle feature for both play and replay

@David53bcg How do you envision this one being implemented in practice? What exactly do you mean by "toggle feature for both play and replay"?

@kevinsung kevinsung linked a pull request Sep 22, 2021 that will close this issue
Open
@kevinsung
Copy link

@David53bcg I have opened #826 to address this issue. I added options to number the variation, or from a hotspot. I believe these are sufficient to address nearly all practical use cases, so I marked the PR as fixing this issue. Let me know if you disagree.

@goodger
Copy link

goodger commented Sep 23, 2021

@kevinsung: Looks good to me. Thank you!

@David53bcg
Copy link
Author

@kevinsung: Many thanks for addressing this issue so well. Greatly appreciated. This improvement will make it so much easier to study middle-game problems/variation, where the clutter of whole-board numbering can be a distraction.

@David53bcg
Copy link
Author

David53bcg commented Sep 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add options to number moves from variation or hotspot kevinsung/Sabaki
4 participants
@apetresc @goodger @kevinsung @David53bcg