Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: Add Bookmark and Comment Options to GameTree Node Menu #940

Open
RobertChrist opened this issue Jun 19, 2023 · 3 comments

Comments

@RobertChrist
Copy link

RobertChrist commented Jun 19, 2023

When navigating the gametree, it is not obvious how to bookmark or change colors of the nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color, you can leave comments on the nodes. But neither of these options are available by right clicking a node, so unless you happen to come across this functionality by leaving a comment and happen to notice the impact, there is nothing that tells the user that this functionality exists.

To rectify this, bookmark, and add comment / set color, should be options in the game tree menu when right clicking a node.

@RobertChrist RobertChrist changed the title Feature Suggestion: Allow Users to Mark GameTree Nodes with Colors Feature Suggestion: Add Bookmark to GameTree Node Menu. Add Colors option. To help navigation Jun 19, 2023
@RobertChrist RobertChrist changed the title Feature Suggestion: Add Bookmark to GameTree Node Menu. Add Colors option. To help navigation Feature Suggestion: Add Bookmark and Comment Options to GameTree Node Menu Jun 20, 2023
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Jul 4, 2023
Issue 940 - SabakiHQ#940

When navigating the gametree, it is not obvious how to
bookmark or change colors of nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color,
you can leave comments on the nodes.  But neither of these
options are available by right clicking a node, so unless you
happen to come across this functionality by leaving a comment
and happen to notice the impact, there is nothing that tells the
user that this functionality exists.

This commit rectifies this by adding these options when right
clicking a node in the gametree.
@RobertChrist
Copy link
Author

RobertChrist commented Jul 4, 2023

#942

I tested with the windows 64 bit build.

RobertChrist added a commit to RobertChrist/sabaki-i18n that referenced this issue Jul 4, 2023
SabakiHQ/Sabaki#940
https://github.com/SabakiHQ/Sabaki/pull/942/files

The above issue requires two new strings, which in turn
require internationalization.

This PR adds these new strings, and additionally adds
the translation for those strings in English,
Spanish, French, and both traditional and
simplified Chinese.
@RobertChrist
Copy link
Author

I have added internationalization support for the menu items with the following PR: SabakiHQ/sabaki-i18n#39, which will also need to be merged.

@RobertChrist
Copy link
Author

Please let me know if there's anything else I can do to move this PR forward

RobertChrist added a commit to RobertChrist/sabaki-i18n that referenced this issue Oct 19, 2023
SabakiHQ/Sabaki#940
https://github.com/SabakiHQ/Sabaki/pull/942/files

The above issue requires two new strings, which in turn
require internationalization.

This PR adds these new strings, and additionally adds
the translation for those strings in English,
Spanish, French, and both traditional and
simplified Chinese.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Oct 19, 2023
Issue 940 - SabakiHQ#940

When navigating the gametree, it is not obvious how to
bookmark or change colors of nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color,
you can leave comments on the nodes.  But neither of these
options are available by right clicking a node, so unless you
happen to come across this functionality by leaving a comment
and happen to notice the impact, there is nothing that tells the
user that this functionality exists.

This commit rectifies this by adding these options when right
clicking a node in the gametree.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Oct 19, 2023
in order to support Sabaki issue SabakiHQ#940 SabakiHQ#940
since the associated il8n PR: SabakiHQ/sabaki-i18n#39
has not yet been merged into the upstream.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Oct 19, 2023
Issue 940 - SabakiHQ#940

When navigating the gametree, it is not obvious how to
bookmark or change colors of nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color,
you can leave comments on the nodes.  But neither of these
options are available by right clicking a node, so unless you
happen to come across this functionality by leaving a comment
and happen to notice the impact, there is nothing that tells the
user that this functionality exists.

This commit rectifies this by adding these options when right
clicking a node in the gametree.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Oct 19, 2023
Issue 940 - SabakiHQ#940

When navigating the gametree, it is not obvious how to
bookmark or change colors of nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color,
you can leave comments on the nodes.  But neither of these
options are available by right clicking a node, so unless you
happen to come across this functionality by leaving a comment
and happen to notice the impact, there is nothing that tells the
user that this functionality exists.

This commit rectifies this by adding these options when right
clicking a node in the gametree.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Oct 19, 2023
in order to support Sabaki issue SabakiHQ#940 SabakiHQ#940
since the associated il8n PR: SabakiHQ/sabaki-i18n#39
has not yet been merged into the upstream.
@apetresc apetresc self-assigned this Jan 4, 2024
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Mar 22, 2024
Issue 940 - SabakiHQ#940

When navigating the gametree, it is not obvious how to
bookmark or change colors of nodes.

To bookmark, you can use hotspots (ctrl+b), and to change color,
you can leave comments on the nodes.  But neither of these
options are available by right clicking a node, so unless you
happen to come across this functionality by leaving a comment
and happen to notice the impact, there is nothing that tells the
user that this functionality exists.

This commit rectifies this by adding these options when right
clicking a node in the gametree.
RobertChrist added a commit to RobertChrist/Sabaki that referenced this issue Mar 22, 2024
in order to support Sabaki issue SabakiHQ#940 SabakiHQ#940
since the associated il8n PR: SabakiHQ/sabaki-i18n#39
has not yet been merged into the upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants