Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on Feature & Unshifted token in Experiments #159

Open
kimjoohyungsd opened this issue Nov 12, 2024 · 2 comments
Open

Question on Feature & Unshifted token in Experiments #159

kimjoohyungsd opened this issue Nov 12, 2024 · 2 comments

Comments

@kimjoohyungsd
Copy link

I am curious how did you guys implemented this experiments. I mean given Figure 6 in eagle 1 as an example, Feautre & unshifted token can be concatenated for tokens generated by Large target model. However, For tokens generated by draft models, How can they get features without running models in advance?

@hongyanz
Copy link
Contributor

It is thus the feature&shifted token. The feature predicted by the draft model goes through an LM head to get a distribution and we can sample the next token from this distribution. In the next round, we concatenate this feature with this sampled token for the next generation. Figure 6 gives a clear description.

@haiduo
Copy link

haiduo commented Dec 24, 2024

Hi @hongyanz @yanjunplay ,
Then may I ask, how is the feature & unshifted-token scheme implemented? From Figure 8 in Eagle1, it seems that feature & shifted-token achieves significant improvements compared to feature & unshifted-token. Additionally, are the differences between feature & shifted-token and feature & unshifted-token reflected during the inference phase or the training phase?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants