From 0aaba301c72c5c63c23ad91988062df2a5e19dee Mon Sep 17 00:00:00 2001
From: bwmac <bwm03570@gmail.com>
Date: Tue, 7 May 2024 12:53:27 -0600
Subject: [PATCH] updates md5 and file extensions teests
---
src/dcqc/suites/suites.py | 4 +---
src/dcqc/tests/file_extension_test.py | 1 +
src/dcqc/tests/md5_checksum_test.py | 1 +
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/dcqc/suites/suites.py b/src/dcqc/suites/suites.py
index 437b2ca..3e792da 100644
--- a/src/dcqc/suites/suites.py
+++ b/src/dcqc/suites/suites.py
@@ -3,11 +3,9 @@
from dcqc.suites.suite_abc import SuiteABC
-# TODO: Consider moving the filetype-test association logic
-# to the file types
class FileSuite(SuiteABC):
file_type = FileType.get_file_type("*")
- # add_tests = (tests.FileExtensionTest, tests.Md5ChecksumTest)
+ add_tests = (tests.FileExtensionTest, tests.Md5ChecksumTest)
class JsonSuite(FileSuite):
diff --git a/src/dcqc/tests/file_extension_test.py b/src/dcqc/tests/file_extension_test.py
index b6206c8..c5fafae 100644
--- a/src/dcqc/tests/file_extension_test.py
+++ b/src/dcqc/tests/file_extension_test.py
@@ -13,5 +13,6 @@ def compute_status(self) -> TestStatus:
file_extensions = file_type.file_extensions
if not file.name.endswith(file_extensions):
status = TestStatus.FAIL
+ self.failure_reason = f"{file.name} does not have one of the expected extensions ({file_extensions}) for file type: {file_type.name}"
break
return status
diff --git a/src/dcqc/tests/md5_checksum_test.py b/src/dcqc/tests/md5_checksum_test.py
index 3a76f16..d009750 100644
--- a/src/dcqc/tests/md5_checksum_test.py
+++ b/src/dcqc/tests/md5_checksum_test.py
@@ -17,6 +17,7 @@ def compute_status(self) -> TestStatus:
status = TestStatus.PASS
else:
status = TestStatus.FAIL
+ self.failure_reason = "Actual MD5 does not match provided value"
return status
def _compute_md5_checksum(self, path: Path) -> str: