Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to skip non-applicable timelines #45

Open
hhunterzinck opened this issue Feb 4, 2022 · 1 comment
Open

Add functionality to skip non-applicable timelines #45

hhunterzinck opened this issue Feb 4, 2022 · 1 comment

Comments

@hhunterzinck
Copy link
Contributor

Some cohorts do not collect data for certain timelines. For example, the BLADDER cohort does not (yet?) collect tumor marker instruments used to create the data_timeline_labtest.txt file. Currently, some of the timelines are not run with a conditional statement checking the cohort inside of the processing code. For example:

if self._SPONSORED_PROJECT not in ["BrCa", "CRC", "NSCLC"]:

It would be more robust to make this more generic to new cohorts or changes in existing cohorts. Perhaps, could the class definitions of each cohort include a flag for each timeline type that is checked during processing in order to proceed with that specific timeline's generation? Or could the potential to create a certain timeline be determined programmatically from the mapping and variables included in the underlying dataset?

@thomasyu888
Copy link
Member

thomasyu888 commented Feb 4, 2022

@hhunterzinck.

Actually, after revisiting this some more, the particular chunk of code highlighted is quite problematic. The reason is because this isn't a file that is created, but it creates a section of the data_timeline_treatment.txt file... Is there a reason why BrCa/CRC/NSCLC don't have the "Radiation Therapy" Treatment type?

A good example of a file that is skipped is "data_timeline_labtest.txt" - this we can achieve with the self._exclude_files we just added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants