Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Start EDAM concept ID from 1 instead of 0 #2563

Closed
1 task done
tschaffter opened this issue Mar 12, 2024 · 3 comments · Fixed by #2564
Closed
1 task done

[Task] Start EDAM concept ID from 1 instead of 0 #2563

tschaffter opened this issue Mar 12, 2024 · 3 comments · Fixed by #2564
Assignees
Labels

Comments

@tschaffter
Copy link
Member

tschaffter commented Mar 12, 2024

What product(s) is this story for?

OpenChallenges

As a user, I want

No response

Description

This is to align with all the other IDs that are generated with AUTO INCREMENT.

References to existing EDAM IDs need to be updated too in input_data_type.csv and challenges.csv (operation_id property).

Depends on #2557

Acceptance criteria

No response

Tasks

No response

Anything else?

No response

Have you linked this story to a GitHub Project?

  • I have linked this story to a GitHub Project and set its metadata.
@tschaffter
Copy link
Member Author

tschaffter commented Mar 12, 2024

The head of the CSV data for input data types:

"id","class_id","preferred_label"
"0","http://edamontology.org/data_0005","Resource type"
"1","http://edamontology.org/data_0006","Data"
"2","http://edamontology.org/data_0007","Tool"

Yet the IDs start with 1 in the SQL table:

image

UPDATE: I set the value of all the id in the EDAM CSV file to null ("\N") and the table in the DB still has IDs set, so it looks like the IDs specified in the CSV file are overwritten by SQL AUTO_INCREMENT.

image

@tschaffter
Copy link
Member Author

This ticket will be addressed by #2564

@vpchung
Copy link
Member

vpchung commented Mar 19, 2024

References to existing EDAM IDs need to be updated too in input_data_type.csv and challenges.csv (operation_id property).

This is already addressed in the OC data sheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants