Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid covering multi line ghost text with menu #928

Closed
ZMProHelper opened this issue Jan 7, 2025 · 5 comments
Closed

Avoid covering multi line ghost text with menu #928

ZMProHelper opened this issue Jan 7, 2025 · 5 comments
Labels
feature New feature or request windows Module which displays UI

Comments

@ZMProHelper
Copy link

ZMProHelper commented Jan 7, 2025 •
edited
Loading

Feature Description

Thank you for this nice plugin!
if menu show at upward diretion, we
can preview code "in place“.
@ZMProHelper ZMProHelper added the feature New feature or request label Jan 7, 2025
@ZMProHelper ZMProHelper changed the title Show menu down-up when virtual text exists Show menu down-up when more than virtual text exists Jan 7, 2025
@ZMProHelper ZMProHelper changed the title Show menu down-up when more than virtual text exists Show menu down-up when more than one line virtual text exists Jan 7, 2025
@Shougo
Copy link

Shougo commented Jan 7, 2025

I think you should upload the example screenshot.
I don't get why the feature is useful.

@Saghen Saghen added the windows Module which displays UI label Jan 7, 2025
@Saghen
Copy link
Owner

Saghen commented Jan 7, 2025 •
edited
Loading

I think the idea is that if the ghost text covers multiple lines, the menu should prefer opening upwards, rather than downwards, to avoid covering the ghost text. As a temporary workaround, you could set your completion.menu.direction_priority to { 's', 'n' }

@Saghen Saghen changed the title Show menu down-up when more than one line virtual text exists Avoid covering multi line ghost text with menu Jan 7, 2025
@ZMProHelper
Copy link
Author

mmexport1736314697301
I can only get this when cursor at the bottom of window now.

@ZMProHelper
Copy link
Author

set completion.menu.direction_priority to { 'n', 's' } has some improvement

@xzbdmw xzbdmw mentioned this issue Jan 8, 2025
Closed
@Saghen
Copy link
Owner

Saghen commented Jan 17, 2025

See #963 (comment)

@Saghen Saghen closed this as completed Jan 17, 2025
@Saghen Saghen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request windows Module which displays UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu): prefer north direction if ghost_text is multiline xzbdmw/blink.cmp
3 participants
@Shougo @Saghen @ZMProHelper