Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the EditorConfig rules #971

Open
jbampton opened this issue Jan 25, 2025 · 5 comments
Open

Respect the EditorConfig rules #971

jbampton opened this issue Jan 25, 2025 · 5 comments
Assignees
Milestone

Comments

@jbampton
Copy link
Member

Hey @BaseMax see the editor config file and make sure your VSC respects its rules.

https://github.com/SalamLang/Salam/blob/main/.editorconfig

Shell scripts are currently indented with tabs !

https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig

refs #970 where I fixed the shell formatting

The Super-Linter shell format check fails when you use spaces for indents.

Make sure you have the EditorConfig plugin installed and working

Tagging @BDadmehr0 here too

@BaseMax
Copy link
Member

BaseMax commented Jan 25, 2025

Image

Which one? @jbampton

@jbampton
Copy link
Member Author

Yes the 11 million downloads one the top one

@jbampton jbampton pinned this issue Jan 25, 2025
@BDadmehr0
Copy link
Member

Hi, I have a question: Are we forced to use plugins in VS Code?
I know that these plugins are available in most editors, but I researched and found out that it’s possible to use CLI tools and some commands to create automated tools for tasks like converting spaces to tabs. Tools like:

  • editorconfig-cli
  • shfmt
  • lint-staged + Super-Linter

For example:

Finding all files:

find . -type f -name "*.sh"

Output:

./build-linux.sh
./build-webassembly.sh
./build/styles/run_all.sh
./build/tags/run_all.sh
./build/data/styles/values/run_all.sh
./build/data/styles/run_all.sh
./build/data/tags/values/run_all.sh
./build/data/tags/run_all.sh

These files can then be passed to CLI formatters.

@jbampton
Copy link
Member Author

Hi @BDadmehr0 no you are not forced you can choose your own.

I don't use VSC or Windows.

But @BaseMax uses VSC

@jbampton
Copy link
Member Author

refs #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants