Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple lights no longer clamping at [1,1,1] #1622

Open
mwitchwilliams opened this issue Nov 10, 2017 · 0 comments
Open

Multiple lights no longer clamping at [1,1,1] #1622

mwitchwilliams opened this issue Nov 10, 2017 · 0 comments
Labels

Comments

@mwitchwilliams
Copy link
Contributor

Testing https://github.com/gearvrf/GearVRf-Tests/tree/master/x3d/animation/animation02.x3d about 3 months ago, produced the following image:
animation0201

The X3D file has 5 lights: a white <PointLight> at [0 -2 -4] plus 4 directional lights:
// 2) reddish light toward -x axis
<DirectionalLight color="1 .25 .25" direction="-1 0 0"/>
// 3) greenish light toward +x axis
<DirectionalLight color=".25 1 .25" direction="1 0 0"/>
// 4) 25% white light toward -z axis
<DirectionalLight color=".25 .25 .25" direction="0 0 -1"/>
// 5) blueish light toward +z axis
<DirectionalLight color=".25 .25 1" direction="0 0 1"/>

The current rendering now looks like this (there is a rotating plane in the scene used to show the green and red lights):
animation02b-master
Plane is rotated further so it is not seen here, which is as expected.
animation02c-master

I'm guessing the light algorithm no longer clamps RGB at [1, 1, 1]. Perhaps now, the <PointLight> RGB [1,1,1] and <DirectionalLight> RGB [.25,.25.25] toward the -z axis is: [1, 1, 1] + [.25, .25, .25] for [1.25, 1.25, 1.25] instead of clamping at [1, 1, 1].

Here is X3D file plus texture maps
animation02.zip

Issue showing up for both master and maint_v3.x releases.

@liaxim liaxim added the bug label Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants