GVRCylinderSceneObject ignores HasBottomCap parameter #1638
Labels
Comments
|
I hope to address this issue the week of December 11 (2017 of course). |
mkeblx
pushed a commit
to mkeblx/GearVRf
that referenced
this issue
Dec 8, 2017
Issue Samsung#1638 Signed-off-by: m.blix <[email protected]>
liaxim
pushed a commit
that referenced
this issue
Dec 11, 2017
Issue #1638 Signed-off-by: m.blix <[email protected]>
|
@SteveGreatApe Fixed by #1661. Can we close the issue? Thanks. |
|
The change looks right, but I'm not using the latest branch so can't actually test it. I did look at moving over to the latest code, but changes to the Picker handling seemed quite complex, and I couldn't find any example to help show to move over to them so I've stuck on 4.0 for now. Maybe that subject needs a new issue itself. |
|
Sure, for the picker created #1666. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The GVRCylinderSceneObject(GVRContext gvrContext, CylinderParams params) version of the constructor ignores the HasBottomCap parameter and always adds the bottom cap. From looking at the code other versions of the constructor might take note of this parameter and work correctly.
The problem is in the
void generateCylinder(CylinderParams params)function, you can see when creating the top cap it checks params.HasTopCap is true, but the similar check when creating the bottom cap is missing.The text was updated successfully, but these errors were encountered: