Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub changed how assets are rendered, breaks juice-shop install #60

Open
JGillam opened this issue Oct 18, 2022 · 2 comments
Open

GitHub changed how assets are rendered, breaks juice-shop install #60

JGillam opened this issue Oct 18, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@JGillam
Copy link
Member

JGillam commented Oct 18, 2022

We used to be able to find the latest release by simply going to https://github.com/juice-shop/juice-shop/releases/latest, following the redirect to the latest tag release, and grepping the correct download link on the page. This is no longer the case, since the page returned does not contain the asset list (this is now fetched in a separate request).

The work around is to use the expanded asset list instead of the /releases/latest page, e.g.:

https://github.com/juice-shop/juice-shop/releases/expanded_assets/v14.3.0

The issue with this approach is, of course, it doesn't auto-update to the latest release.

@JGillam JGillam added the bug Something isn't working label Oct 18, 2022
@Bl0ckbuster
Copy link
Contributor

I think I've devised a way to keep the juice-shop.yml intact, and still pull from /releases/latest - I'm adding that pull request now.

@double16
Copy link
Contributor

This should be fixed now, it's using a docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants