Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse computed I(qx,qy) values when computing 2D resolution (Trac #716) #114

Open
pkienzle opened this issue Mar 30, 2019 · 2 comments
Open

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

sasmodels/resolution2D.py sets the calculated qx,qy points by drawing NR x NPHI points around each measured point qx,qy. This means that the 2D pattern is computed 12, 30, 60, or 200 times depending on the choice of accuracy.

Rather than blindly drawing this many points around each qx,qy, we should first check if there are enough points already being computed in the pattern, and only add points where more are needed. This has the potential for significant speedup of 2D calculations when the resolution is worse than the pixel spacing.

Migrated from http://trac.sasview.org/ticket/716

{
    "status": "new",
    "changetime": "2019-03-02T01:09:26",
    "_ts": "2019-03-02 01:09:26.524573+00:00",
    "description": "sasmodels/resolution2D.py sets the calculated qx,qy points by drawing NR x NPHI points around each measured point qx,qy.  This means that the 2D pattern is computed 12, 30, 60, or 200 times depending on the choice of accuracy.\n\nRather than blindly drawing this many points around each qx,qy, we should first check if there are enough points already being computed in the pattern, and only add points where more are needed.  This has the potential for significant speedup of 2D calculations when the resolution is worse than the pixel spacing.",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasModels Infrastructure",
    "time": "2016-10-06T16:25:53",
    "component": "sasmodels",
    "summary": "reuse computed I(qx,qy) values when computing 2D resolution",
    "priority": "major",
    "keywords": "",
    "milestone": "sasmodels 1.0",
    "owner": "",
    "type": "enhancement"
}
@pkienzle
Copy link
Contributor Author

Trac update at 2019/02/21 04:41:49:

  • pkienzle changed component from "SasView" to "sasmodels"
  • pkienzle changed milestone from "SasView Next Release +1" to "sasmodels 1.0"
  • pkienzle changed workpackage from "SasView Bug Fixing" to "SasModels Redesign"

@butlerpd
Copy link
Member

Trac update at 2019/03/02 01:09:26: butler changed workpackage from "SasModels Redesign" to "SasModels Infrastructure"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants