Need to Refactor SimultaneousFitPage Class (Trac #942)

[butlerpd]

It turns out that the !SimultaneousFitPage class in simfitpage.py is used both for constrained/simultaneous fitting and for combined batch fitting. Most of th page is the same but there are a dozen instances requiring one or two lined of code change that are all done using "if batch_on...."

This is bad form. Ideally the class should be rewritten to be generic and then two subclasses written which inherit from that class. All could reside in the one file.

However, since this is in sasgui which goes away soon and does not affect the user experience it has a trivial priority and will presumably be closed as obsolete after 5.0 if not fixed first.

Migrated from http://trac.sasview.org/ticket/942

{
    "status": "new",
    "changetime": "2017-10-23T14:28:03",
    "_ts": "2017-10-23 14:28:03.845491+00:00",
    "description": "It turns out that the !SimultaneousFitPage class in simfitpage.py is used both for constrained/simultaneous fitting and for combined batch fitting.  Most of th page is the same but there are a dozen instances requiring one or two lined of code change that are all done using \"if batch_on....\"\n\nThis is bad form.  Ideally the class should be rewritten to be generic and then two subclasses written which inherit from that class.  All could reside in the one file.\n\nHowever, since this is in sasgui which goes away soon and does not affect the user experience it has a trivial priority and will presumably be closed as obsolete after 5.0 if not fixed first.",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Framework Enhancements",
    "time": "2017-04-09T14:28:50",
    "component": "SasView",
    "summary": "Need to Refactor SimultaneousFitPage Class",
    "priority": "trivial",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "",
    "type": "defect"
}

[butlerpd]

Trac update at 2017/10/23 14:28:03:

• butler commented:

No point in doing this in old gui. Probably irrelevant in new GUI but move to 5.0 for now anyway?

• butler changed milestone from "SasView 4.2.0" to "SasView 5.0.0"

[rozyczko]

I'd like to keep this since I want to refactor FittingWidget for 5.1
This module grew enormously and is due for serious refactoring.