Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the parameter names for complex mixture models (Trac #1065) #1120

Open
pkienzle opened this issue Mar 30, 2019 · 2 comments
Open

Check the parameter names for complex mixture models (Trac #1065) #1120

pkienzle opened this issue Mar 30, 2019 · 2 comments
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

mixtures including product models don't have the correct parameter names.

For example

$ sascomp cylinder+sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
scale: 1
sld: 1
sld_solvent: 6
radius: 50
volfraction: 0.2

should be:

$ sascomp cylinder+sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
B_scale: 1
B_sld: 1
B_sld_solvent: 6
B_radius: 50
B_volfraction: 0.2

and

$ sascomp cylinder+ellipsoid*sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
C_scale: 1
C_sld: 4
C_sld_solvent: 1
C_radius: 20
C_length: 400
C_theta: 60
C_phi: 60
Asldradiusvolfraction_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius_polar: 20
A_radius_equatorial: 400
A_theta: 60
A_phi: 60
sld: 1
sld_solvent: 6
radius: 50
volfraction: 0.2

should be

scale: 1
background: 0.001
C_scale: 1
C_sld: 4
C_sld_solvent: 1
C_radius: 20
C_length: 400
C_theta: 60
C_phi: 60
AB_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius_polar: 20
A_radius_equatorial: 400
A_theta: 60
A_phi: 60
B_sld: 1
B_sld_solvent: 6
B_radius: 50
B_volfraction: 0.2

or perhaps keeping the order of the terms in the original expression

scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
BC_scale: 1
B_sld: 4
B_sld_solvent: 1
B_radius_polar: 20
B_radius_equatorial: 400
B_theta: 60
B_phi: 60
C_sld: 1
C_sld_solvent: 6
C_radius: 50
C_volfraction: 0.2

Migrated from http://trac.sasview.org/ticket/1065

{
    "status": "new",
    "changetime": "2018-07-03T14:30:01",
    "_ts": "2018-07-03 14:30:01.432883+00:00",
    "description": "mixtures including product models don't have the correct parameter names.\n\nFor example\n```\n$ sascomp cylinder+sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nscale: 1\nsld: 1\nsld_solvent: 6\nradius: 50\nvolfraction: 0.2\n```\nshould be:\n```\n$ sascomp cylinder+sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nB_scale: 1\nB_sld: 1\nB_sld_solvent: 6\nB_radius: 50\nB_volfraction: 0.2\n```\n\nand\n```\n$ sascomp cylinder+ellipsoid*sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nC_scale: 1\nC_sld: 4\nC_sld_solvent: 1\nC_radius: 20\nC_length: 400\nC_theta: 60\nC_phi: 60\nAsldradiusvolfraction_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius_polar: 20\nA_radius_equatorial: 400\nA_theta: 60\nA_phi: 60\nsld: 1\nsld_solvent: 6\nradius: 50\nvolfraction: 0.2\n```\nshould be\n```\nscale: 1\nbackground: 0.001\nC_scale: 1\nC_sld: 4\nC_sld_solvent: 1\nC_radius: 20\nC_length: 400\nC_theta: 60\nC_phi: 60\nAB_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius_polar: 20\nA_radius_equatorial: 400\nA_theta: 60\nA_phi: 60\nB_sld: 1\nB_sld_solvent: 6\nB_radius: 50\nB_volfraction: 0.2\n```\nor perhaps keeping the order of the terms in the original expression\n```\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nBC_scale: 1\nB_sld: 4\nB_sld_solvent: 1\nB_radius_polar: 20\nB_radius_equatorial: 400\nB_theta: 60\nB_phi: 60\nC_sld: 1\nC_sld_solvent: 6\nC_radius: 50\nC_volfraction: 0.2\n```\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "Beta Approximation Project",
    "time": "2018-01-24T14:59:11",
    "component": "SasView",
    "summary": "Check the parameter names for complex mixture models",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "",
    "type": "defect"
}
@pkienzle pkienzle added this to the SasView Next Release +1 milestone Mar 30, 2019
@pkienzle pkienzle added Beta Approximation Project Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2018/02/13 02:46:35: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

@RichardHeenan
Copy link
Contributor

Trac update at 2018/07/03 14:30:01:

  • richardh commented:

temporarily move to beta(Q) project, as is related to tickets there.

  • richardh changed milestone from "SasView 4.3.0" to "SasView Next Release +1"
  • richardh changed workpackage from "SasView Bug Fixing" to "Beta Approximation Project"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

5 participants