Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5 user level, changes to model tab (Trac #1116) #241

Closed
RichardHeenan opened this issue Mar 30, 2019 · 14 comments
Closed

qt5 user level, changes to model tab (Trac #1116) #241

RichardHeenan opened this issue Mar 30, 2019 · 14 comments
Assignees

Comments

@RichardHeenan
Copy link
Contributor

Consider adding "+" symbol drop downs with details for S(Q) radius & volume parameters, analogous to those for polydisperse radii.

Migrated from http://trac.sasview.org/ticket/1116

{
    "status": "assigned",
    "changetime": "2018-09-09T08:00:06",
    "_ts": "2018-09-09 08:00:06.919320+00:00",
    "description": "Consider adding \"+\" symbol drop downs with details for S(Q) radius & volume parameters, analogous to those for polydisperse radii.",
    "reporter": "richardh",
    "cc": "",
    "resolution": "",
    "workpackage": "Beta Approximation Project",
    "time": "2018-07-01T21:10:57",
    "component": "SasView",
    "summary": "qt5 user level, changes to model tab",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "tcbennun",
    "type": "enhancement"
}
@sasview-bot
Copy link

Trac update at 2018/07/24 14:34:38:

  • tcbennun commented:

Following today's conf call I'll focus on this approach.

  • tcbennun changed owner from "" to "tcbennun"
  • tcbennun changed status from "new" to "assigned"

@sasview-bot
Copy link

Trac update at 2018/07/24 14:34:51: tcbennun changed milestone from "SasView Next Release +1" to "SasView 5.0.0"

@sasview-bot
Copy link

Trac update at 2018/07/24 15:07:48: tcbennun commented:

opened JIRA issue:


'''SASVIEW-967'''
'''tcbennun, 24 Jul 2018 16:05'''

As part of the greater beta approximation project, the following features shall be implemented in the Model tab of fit pages:

  • In the parameter table, the S(Q) parameters radius_effective and volfraction shall have sub-items that allow user choice between generation from P(Q) model, or free/fitting.
  • An option to enable the beta approximation for the current model shall be added.

These changes are compatible only with product models, i.e. a simple P(Q)*S(Q) model. The GUI additions here should leave room for the future support of mixture models with one or more products, i.e. (P_1(Q) + ...)*S_1(Q) + (P_i(Q) + ...)*S_2(Q) + ...

In product models, the flag for enabling beta approximation will manifest as a model parameter with possible values of 0 or 1.

@sasview-bot
Copy link

Trac update at 2018/08/02 16:08:46:

  • tcbennun changed attachment from "" to "functional_constraint_enabled.png"
  • tcbennun commented:

Example of enabled functional constraint in QT GUI, as child row of the parameter

@sasview-bot
Copy link

Trac update at 2018/08/02 16:09:03:

  • tcbennun changed attachment from "" to "functional_constraint_disabled.png"
  • tcbennun commented:

Example of disabled functional constraint in QT GUI, as child row of the parameter

@sasview-bot
Copy link

Trac update at 2018/08/02 16:12:12: tcbennun commented:

In ESS_GUI_beta_approx, added demonstration of what it may look like to choose between constraining effective_radius (for example) and letting it be a fittable parameter.

When constrained (I call it a 'functional constraint') to the value of some_func:

[[Image(functional_constraint_enabled.png)]]

And when it is fittable/free:

[[Image(functional_constraint_disabled.png)]]

Selecting a function to use as a constraint changes the row visually, and removes user-input values. It could enable the 'Value' column to show the calculated parameter, too.

@sasview-bot
Copy link

Trac update at 2018/08/09 10:27:19:

  • tcbennun changed attachment from "" to "calculation_mode.png"
  • tcbennun commented:

Setting of product calculation mode in QT GUI.

@sasview-bot
Copy link

Trac update at 2018/08/09 10:28:03: tcbennun commented:

A product calculation mode combo box has been added; it controls the beta_mode parameter injected into product models (only in the beta_approx sasmodels branch).

[[Image(calculation_mode.png)]]

The possible options are taken from the limits field of the beta_mode parameter.

@sasview-bot
Copy link

Trac update at 2018/08/09 10:28:27: tcbennun commented:

Note: the model is re-calculated immediately upon selection of a calculation mode.

@sasview-bot
Copy link

Trac update at 2018/08/20 08:54:19: tcbennun commented:

After correspondence with Paul Kienzle, it looks appropriate to treat beta_mode as a normal model parameter, but one that has fixed choices and is not fittable. Such a parameter will be displayed in the GUI in the parameter table, but with a combo-box for selection. This approach allows for further addition of such fixed parameters; also, in the case of complicated mixture models where more than one product model is a constituent, the separate beta_mode parameters will be clear.

@sasview-bot
Copy link

Trac update at 2018/08/21 12:42:28: tcbennun changed attachment from "" to "beta_mode_parameter.png"

@sasview-bot
Copy link

Trac update at 2018/08/21 12:44:35: tcbennun commented:

The beta mode parameter is now part of the parameter table (its location in the table is not yet fixed). It is a non-fittable (therefore non-checkable) parameter:

[[Image(beta_mode_parameter.png)]]

The possible options are PS or P(1+beta*(S-1)); these correspond internally to 0 or 1 (to turn beta mode off or on). It is perfectly easy to rename the parameter or add further options without breaking the GUI because it is treated generically.

@sasview-bot
Copy link

Trac update at 2018/09/09 08:00:06: tcbennun commented:

The features detailed above in my previous comments are now merged into ESS_GUI.

Additionally, ESS_GUI_iss1052 has functionality for effective radius options, see #888.

Volume options will go down a similar route.

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@butlerpd
Copy link
Member

butlerpd commented May 2, 2021

This I think has been long finished so am going to close. If there are more tweaks requested they should be a separate ticket.

@butlerpd butlerpd closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants