-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5 user level, changes to model tab (Trac #1116) #241
Comments
Trac update at
Following today's conf call I'll focus on this approach.
|
Trac update at |
Trac update at opened JIRA issue: '''SASVIEW-967''' As part of the greater beta approximation project, the following features shall be implemented in the Model tab of fit pages:
These changes are compatible only with product models, i.e. a simple P(Q)*S(Q) model. The GUI additions here should leave room for the future support of mixture models with one or more products, i.e. (P_1(Q) + ...)*S_1(Q) + (P_i(Q) + ...)*S_2(Q) + ... In product models, the flag for enabling beta approximation will manifest as a model parameter with possible values of 0 or 1. |
Trac update at
Example of enabled functional constraint in QT GUI, as child row of the parameter |
Trac update at
Example of disabled functional constraint in QT GUI, as child row of the parameter |
Trac update at In ESS_GUI_beta_approx, added demonstration of what it may look like to choose between constraining effective_radius (for example) and letting it be a fittable parameter. When constrained (I call it a 'functional constraint') to the value of some_func: [[Image(functional_constraint_enabled.png)]] And when it is fittable/free: [[Image(functional_constraint_disabled.png)]] Selecting a function to use as a constraint changes the row visually, and removes user-input values. It could enable the 'Value' column to show the calculated parameter, too. |
Trac update at
Setting of product calculation mode in QT GUI. |
Trac update at A product calculation mode combo box has been added; it controls the [[Image(calculation_mode.png)]] The possible options are taken from the |
Trac update at Note: the model is re-calculated immediately upon selection of a calculation mode. |
Trac update at After correspondence with Paul Kienzle, it looks appropriate to treat beta_mode as a normal model parameter, but one that has fixed choices and is not fittable. Such a parameter will be displayed in the GUI in the parameter table, but with a combo-box for selection. This approach allows for further addition of such fixed parameters; also, in the case of complicated mixture models where more than one product model is a constituent, the separate beta_mode parameters will be clear. |
Trac update at |
Trac update at The beta mode parameter is now part of the parameter table (its location in the table is not yet fixed). It is a non-fittable (therefore non-checkable) parameter: [[Image(beta_mode_parameter.png)]] The possible options are PS or P(1+beta*(S-1)); these correspond internally to 0 or 1 (to turn beta mode off or on). It is perfectly easy to rename the parameter or add further options without breaking the GUI because it is treated generically. |
Trac update at The features detailed above in my previous comments are now merged into ESS_GUI. Additionally, ESS_GUI_iss1052 has functionality for effective radius options, see #888. Volume options will go down a similar route. |
This I think has been long finished so am going to close. If there are more tweaks requested they should be a separate ticket. |
Consider adding "+" symbol drop downs with details for S(Q) radius & volume parameters, analogous to those for polydisperse radii.
Migrated from http://trac.sasview.org/ticket/1116
The text was updated successfully, but these errors were encountered: