Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external calls to sasmodels needing beta(Q) (Trac #1119) #1163

Closed
RichardHeenan opened this issue Mar 30, 2019 · 4 comments
Closed

external calls to sasmodels needing beta(Q) (Trac #1119) #1163

RichardHeenan opened this issue Mar 30, 2019 · 4 comments
Assignees
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Milestone

Comments

@RichardHeenan
Copy link
Contributor

RichardHeenan commented Mar 30, 2019

Do we need to consider how other codes will be able to call sasmodels in such as way as to get beta(Q) and other options in the calculation of I(Q)?

Migrated from http://trac.sasview.org/ticket/1119

{
    "status": "closed",
    "changetime": "2018-10-30T22:09:29",
    "_ts": "2018-10-30 22:09:29.035043+00:00",
    "description": "Do we need to consider how other codes will be able to call sasmodels in such as way as to get beta(Q) and other options in the calculation of I(Q)?",
    "reporter": "richardh",
    "cc": "",
    "resolution": "duplicate",
    "workpackage": "Beta Approximation Project",
    "time": "2018-07-01T21:32:04",
    "component": "SasView",
    "summary": "external calls to sasmodels needing beta(Q)",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "richardh",
    "type": "enhancement"
}
@RichardHeenan RichardHeenan added this to the SasView 5.0.0 milestone Mar 30, 2019
@RichardHeenan RichardHeenan self-assigned this Mar 30, 2019
@RichardHeenan RichardHeenan added Beta Approximation Project Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2018/09/09 07:56:15: butler changed _comment0 from:

External code can use several methods to run sasmodels, but in the beta_approx branch, the SasviewModel class has an API change in place allowing access to intermediate results from the P(Q)S(Q) calculation.

SasviewModel.calculate_Iq now returns both I(Q) and a callable; the callable is used to generate a dict of intermediate results. beta(Q) is one of those results, if beta approximation is turned on. If the model in question is not a product model, the callable returns an empty dict.

This is a breaking change for any existing calls to calculate_Iq, so if/when this is introduced into master, it must be under a new major version number (I recommend).

to:

1536480138178319

@sasview-bot
Copy link

Trac update at 2018/09/09 07:56:15: tcbennun commented:

External code can use several methods to run sasmodels, but in the beta_approx branch, the !SasviewModel class has an API change in place allowing access to intermediate results from the P(Q)S(Q) calculation.

!SasviewModel.calculate_Iq now returns both I(Q) and a callable; the callable is used to generate a dict of intermediate results. beta(Q) is one of those results, if beta approximation is turned on. If the model in question is not a product model, the callable returns an empty dict.

This is a breaking change for any existing calls to calculate_Iq, so if/when this is introduced into master, it must be under a new major version number (I recommend).

@butlerpd
Copy link
Member

Trac update at 2018/09/09 08:02:47: butler changed milestone from "sasmodels Next Release +1" to "SasView 5.0.0"

@pkienzle
Copy link
Contributor

Trac update at 2018/10/30 22:09:29:

  • pkienzle commented:

For scripts that use the sasview model wrapper (if any), the first release of beta approximation will be in sasmodels 1.0, so it will be in a new major revision.

Closing this as dup of http://trac.sasview.org/ticket/491.

  • pkienzle changed resolution from "" to "duplicate"
  • pkienzle changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

4 participants