Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array distribution not respecting hard limits on parameter (Trac #1177) #1213

Open
pkienzle opened this issue Mar 30, 2019 · 0 comments
Open
Labels
Defect Bug or undesirable behaviour McSAS McSAS Integration Project Minor Small job

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

In sasmodels.sasview_model.SasviewModel._get_weights the array distribution values are returned directly as the weights for the parameter regardless of what hard limits are set in the model definition file.

This is not a problem, since most models that have hard limits also have a test for VALID that keeps the parameters within the hard limits.

Note that the weights.ArrayDistribution class does respect the hard limits when returning the distribution, but this is not used in the SasviewModel._get_weights method, so the fix should start there.

Migrated from http://trac.sasview.org/ticket/1177

{
    "status": "new",
    "changetime": "2018-09-17T16:34:44",
    "_ts": "2018-09-17 16:34:44.334691+00:00",
    "description": "In `sasmodels.sasview_model.SasviewModel._get_weights` the array distribution values are returned directly as the weights for the parameter regardless of what hard limits are set in the model definition file.\n\nThis is not a problem, since most models that have hard limits also have a test for VALID that keeps the parameters within the hard limits.\n\nNote that the `weights.ArrayDistribution` class does respect the hard limits when returning the distribution, but this is not used in the `SasviewModel._get_weights` method, so the fix should start there.",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "McSAS Integration Project",
    "time": "2018-09-17T16:34:44",
    "component": "SasView",
    "summary": "array distribution not respecting hard limits on parameter",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "",
    "type": "defect"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour McSAS McSAS Integration Project Minor Small job
Projects
None yet
Development

No branches or pull requests

3 participants