Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be_polyelectrolyte model needs proper validation check (Trac #1186) #394

Open
butlerpd opened this issue Mar 30, 2019 · 1 comment
Open

Comments

@butlerpd
Copy link
Member

An error in the be_polyelectrolyte model was identified prior to release 4.2.0 and corrected. The error has been carried since 1998 and there was no quick and easy external validation of that change, partly because the implementation doesn't exactly follow the paper. It would be good if somebody could go through the paper and ensure that the code follows so that the disclaimer note in the docs can be removed.

Migrated from http://trac.sasview.org/ticket/1186

{
    "status": "new",
    "changetime": "2018-09-28T17:32:06",
    "_ts": "2018-09-28 17:32:06.332106+00:00",
    "description": "An error in the be_polyelectrolyte model was identified prior to release 4.2.0 and corrected.  The error has been carried since 1998 and there was no quick and easy external validation of that change, partly because the implementation doesn't exactly follow the paper.  It would be good if somebody could go through the paper and ensure that the code follows so that the disclaimer note in the docs can be removed.",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "McSAS Integration Project",
    "time": "2018-09-28T17:32:06",
    "component": "SasView",
    "summary": "be_polyelectrolyte model needs proper validation check",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "defect"
}
rprospero referenced this issue in rprospero/sasview May 28, 2019
Added check for self.model to _set_smear_buttons and more info logging.
Smear buttons should now be enabled depending on 2D vs 1D, model or not,
and resolution data available or not.

Addresses #1222
rprospero referenced this issue in rprospero/sasview May 28, 2019
Ticket 1206 - fix problems in smearing sizer

Fixes SasView#1206
Fixes #1222
@butlerpd
Copy link
Member Author

This is clearly a sasmodels issue not a sasview on so moving it over now.

@butlerpd butlerpd transferred this issue from SasView/sasview Apr 26, 2020
@butlerpd butlerpd added this to the sasmodels 1.1 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant