Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve implementation of Si and JN (Trac #1193) #356

Open
pkienzle opened this issue Mar 30, 2019 · 2 comments
Open

improve implementation of Si and JN (Trac #1193) #356

pkienzle opened this issue Mar 30, 2019 · 2 comments

Comments

@pkienzle
Copy link
Contributor

sasmodels implementation of Si and JN are very badly behaved across much of their range.

Migrated from http://trac.sasview.org/ticket/1193

{
    "status": "new",
    "changetime": "2018-11-15T16:25:24",
    "_ts": "2018-11-15 16:25:24.117589+00:00",
    "description": "sasmodels implementation of Si and JN are very badly behaved across much of their range.",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "McSAS Integration Project",
    "time": "2018-10-12T20:17:10",
    "component": "SasView",
    "summary": "improve implementation of Si and JN",
    "priority": "major",
    "keywords": "",
    "milestone": "sasmodels 1.0",
    "owner": "",
    "type": "defect"
}
@pkienzle
Copy link
Contributor Author

Trac update at 2018/11/15 16:25:24: pkienzle commented:

The cephes implementation of Si is more accurate than that which we are using in sasmodels. Consider using it instead.

@pkienzle
Copy link
Contributor Author

Use explore/precision.py to see the difference. For example:

$ python explore/precision.py Si

produces:

image

Similarly for J_{-3}, J_3 and J_2:

$ python explore/precision.py J-3
$ python explore/precision.py J3
$ python explore/precision.py J2

@butlerpd butlerpd modified the milestones: sasmodels 1.0, sasmodels 1.1 Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants