Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P(Q)S(Q) & Integration Complexities #1470

Open
smk78 opened this issue Mar 11, 2020 · 0 comments
Open

P(Q)S(Q) & Integration Complexities #1470

smk78 opened this issue Mar 11, 2020 · 0 comments
Labels
Plotting Concerns plotting functionality
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Mar 11, 2020

This is harder, but hoping to help us see where we have been and where we are going, at least as far as things that interest myself! - and to then write some tickets,

So is much a work in progress …

Richard

Beta(Q)

The beta(Q) work for S(Q) is I think all working (for simple cases) and is even documented SasView/sasmodels#203

But we are woefully short on unit tests, though prototypes exist for key models such as ellipsoid. http://trac.sasview.org/ticket/822#comment:2

Validation of beta(Q) etc. against other codes is tricky, and has some unresolved issues SasView/sasmodels#181

Numerical Integrations

Paul K has notes here on how numerical integrations can be improved SasView/sasmodels#244
Also comments on adaptive integration here SasView/sasmodels#535 and Q resolution smearing #839

parallelize polydispersity loops (especially important for McSAS) https://github.com/SasView/sasview/issues/1259 , see also SasView/sasmodels#187

Parameter passing

Models need to be able to feed back some derived values at least at mean or starting values of parameters (e.g. shell thickness where this is computed, or say Vshell/Vcore as information to user) SasView/sasmodels#182

Sum & Multi complex models & plugin models

Some historical context here, about backwards compatibility for sum/multi from older project files SasView/sasmodels#179

“Mixture model needs to be rewritten” says Paul K #1305 , also related comment #1333

P(Q)S(Q) plugin not working ??? - needs test - created #1478 for this., see also
#1301
#1451 which was merged to master of sasmodels - see SasView/sasmodels#216

plugin sun of three models not working in v4 or v5,see
v4 #1359
v5 #1360

this may be partly fixed, as there is a closed pulll request with unmerged commits ?
SasView/sasmodels#364
and a closed branch of sasmodels https://github.com/SasView/sasmodels/tree/ticket_1360_add_models

Plugin model summed with another plugin not working #1451

Yet more on constraints

Additional fixed parameters (though a plugin model plus constraints could do this easily) #978

Ought to close this one ? #621

Scale factors

As with the recent email discussion with Ad van Well, there are lengthy discussions here SasView/sasmodels#232 about the meaning of the “scale” parameter and what we might do about improving things whilst also maintaining backwards compatibility, else we make a great leap forward in v6 !
See also #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plotting Concerns plotting functionality
Projects
None yet
Development

No branches or pull requests

4 participants