Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Orientation Viewer in 5x #1763

Closed
smk78 opened this issue Jan 22, 2021 · 3 comments · Fixed by #2394
Closed

Implement the Orientation Viewer in 5x #1763

smk78 opened this issue Jan 22, 2021 · 3 comments · Fixed by #2394
Assignees
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements For Feature Parity Issues to give 5x the same functionality as 4x

Comments

@smk78
Copy link
Contributor

smk78 commented Jan 22, 2021

#1271 noted that the Orientation Viewer present in 4x needed to be implemented in 5x. However, until now, that requirement does not appear to have been ticketed.

@smk78 smk78 added Defect Bug or undesirable behaviour SasView GUI Enhancements For Feature Parity Issues to give 5x the same functionality as 4x labels Jan 22, 2021
@smk78 smk78 added this to the SasView Next Release +1 milestone Jan 22, 2021
@rozyczko
Copy link
Member

Hmm we had the Orientation Viewer implemented at some point...

@rozyczko
Copy link
Member

ah.

 # orientation viewer set to invisible SASVIEW-1132
 self._workspace.actionOrientation_Viewer.setVisible(False)

this points to the bug report in JIRA
https://jira.esss.lu.se/browse/SASVIEW-1132

On Mac, only the following error message is displayed in the Log explorer:
"ERROR: Unknown property axisbg"

matplotlib > 3.0 doesn't have axisbg property for Axes. it is now 'facecolor'. The orientation viewer runs from sasmodels.
We will downgrade matplotlib on linux/mac until proper rewrite of sasmodels is done. mpl 3.0 is not yet available for windows on conda, so we didn't see the issue before.

So I think this means we need to check if sasmodels is now MPL 3 compliant and if so, just enable the viewer.

@rozyczko rozyczko self-assigned this Jan 26, 2021
@rozyczko
Copy link
Member

This needs some work now. When no plots are shown, the orientation viewer performs as expected. When a plot is shown, it gets replotted in a separate window, and the original plot canvas turns blank.

jitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements For Feature Parity Issues to give 5x the same functionality as 4x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants