No Check Model functionality in 5.x

[smk78]

In 4.x, the Advanced Plugin Model Editor incorporates functionality to check the validity of the code in the selected plugin (Run > Check Model):

The output is extremely valuable for debugging plugin models:

In this instance, for example, highlighting that the User had used define random(): instead of def random():

In 4.x this output is not duplicated in either the Console or sasview.txt.

Unfortunately there is no equivalent Check Model functionality in 5.x (the following screenshots are from 5.04 RC3):

The issue here is that if 5.x cannot compile a plugin then it simply passes over it. Nothing to say it could not compile a plugin is output to the Log Explorer or sasview.txt. This actually makes 5.x pretty much useless for developing or tweaking a plugin by editing the code.

Can the Check Model functionality be reinstated in 5.x?

[rozyczko]

Yes, this is indeed missing. Wx had a nice python editor/syntax checker built in, but Qt has nothing like that so far.
Reimplementing this functionality in Qt will be a pretty hefty effort, unless there is a ready component out there we can reuse.

[rozyczko]

QScintilla2 might be a solution to that... investigating

[rozyczko]

using ast along with showing the results with traceback seems to be doing the trick.

[butlerpd]

Just did a quick search on ast -- that does seem promising!!

[rozyczko]

Added a syntax check for the edit model window.
Also, added support for line numbers and current row highlighting

branch: improved_model_check

[krzywon]

This was fixed with #1875