Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with RPA model in ESS_GUI 5.x #2022

Closed
smk78 opened this issue Feb 15, 2022 · 5 comments
Closed

Problem with RPA model in ESS_GUI 5.x #2022

smk78 opened this issue Feb 15, 2022 · 5 comments
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Feb 15, 2022

This issue is a pointer to a sasmodels issue, the cause and resolution of which is unclear but which could actually be (probably is) a SasView GUI problem.

See SasView/sasmodels#396

The issue itself, however, is serious.

@smk78 smk78 added Defect Bug or undesirable behaviour SasView Bug Fixing Blocker Prevents a different issue from being resolved labels Feb 15, 2022
@smk78 smk78 added this to the SasView 5.0.5 milestone Feb 15, 2022
@rozyczko
Copy link
Member

This is a SasView GUI issue and needs quite a lot of work. Given the problem was around for several 5.0.x releases it probably would be safer to address it in the next release cycle.

@butlerpd
Copy link
Member

Oops ... I thought it was agreed that the fix is related to completely redoing how sasview handles the control parameters from sasmodels which is clearly beyond anything that can be achieved for 5.0.5. The confusion maybe that for 5.0.5, or more precisely sasmodels 1.0.6, a note was added to the model in sasmodels. Perhaps this is in 5.0.5 in case there is some note that can be placed in the GUI for when that model, and only that model, is chosen? But I don't think the GUI structure allows that in any reasonable way?

Otherwise, I second the motion that this should move to 5.1

@rozyczko
Copy link
Member

We can remove rpa from the gui altogether?
This would be a pretty simple, easily reversible fix.

@butlerpd
Copy link
Member

?? Really @rozyczko ? basically so it does not show up in the dropdown even though it is part of the sasmodels package? If so we should probably do that. That would be awesome. I thought that would be nearly impossible. I guess I don't know how that list is loaded and categorized?

timsnow added a commit that referenced this issue Mar 1, 2022
Don't show RPA in the list of models #2022
@smk78
Copy link
Contributor Author

smk78 commented Mar 1, 2022

This issue is fixed by the merge above so closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

3 participants