-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with RPA model in ESS_GUI 5.x #2022
Comments
This is a SasView GUI issue and needs quite a lot of work. Given the problem was around for several 5.0.x releases it probably would be safer to address it in the next release cycle. |
Oops ... I thought it was agreed that the fix is related to completely redoing how sasview handles the control parameters from sasmodels which is clearly beyond anything that can be achieved for 5.0.5. The confusion maybe that for 5.0.5, or more precisely sasmodels 1.0.6, a note was added to the model in sasmodels. Perhaps this is in 5.0.5 in case there is some note that can be placed in the GUI for when that model, and only that model, is chosen? But I don't think the GUI structure allows that in any reasonable way? Otherwise, I second the motion that this should move to 5.1 |
We can remove rpa from the gui altogether? |
?? Really @rozyczko ? basically so it does not show up in the dropdown even though it is part of the sasmodels package? If so we should probably do that. That would be awesome. I thought that would be nearly impossible. I guess I don't know how that list is loaded and categorized? |
Don't show RPA in the list of models #2022
This issue is fixed by the merge above so closing this ticket. |
This issue is a pointer to a sasmodels issue, the cause and resolution of which is unclear but which could actually be (probably is) a SasView GUI problem.
See SasView/sasmodels#396
The issue itself, however, is serious.
The text was updated successfully, but these errors were encountered: