Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots should be linked to fits. (Trac #13) #242

Closed
sasview-bot opened this issue Mar 30, 2019 · 20 comments
Closed

Plots should be linked to fits. (Trac #13) #242

sasview-bot opened this issue Mar 30, 2019 · 20 comments
Labels
Critical High priority Enhancement Feature requests and/or general improvements Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable.
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

There should be a link between the fit panel and the related plots so that it is easy to locate which plots belong to the fit you are looking at.

Migrated from http://trac.sasview.org/ticket/13

{
    "status": "new",
    "changetime": "2019-03-28T18:04:50",
    "_ts": "2019-03-28 18:04:50.146152+00:00",
    "description": "There should be a link between the fit panel and the related plots so that it is easy to locate which plots belong to the fit you are looking at.",
    "reporter": "ajjackson",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView GUI Enhancements",
    "time": "2012-03-29T10:33:08",
    "component": "SasView",
    "summary": "Plots should be linked to fits.",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "",
    "type": "enhancement"
}
@sasview-bot sasview-bot added this to the SasView 5.0.0 milestone Mar 30, 2019
@sasview-bot sasview-bot added Critical High priority Enhancement Feature requests and/or general improvements Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2012/03/29 21:52:47: butlerpd changed type from "defect" to "enhancement"

@butlerpd
Copy link
Member

Trac update at 2012/05/06 16:10:39: butlerpd changed milestone from "" to "WishList"

@butlerpd
Copy link
Member

Trac update at 2015/01/30 01:08:13: butler changed workpackage from "" to "Plotting/Graphing Enhancements"

@butlerpd
Copy link
Member

Trac update at 2015/08/14 20:31:45: butler changed milestone from "WishList" to "SasView Next Release +1"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2017/01/17 13:05:47: ajj changed component from "SansView" to "SasView"

@butlerpd
Copy link
Member

Trac update at 2017/10/23 12:39:53: butler changed milestone from "SasView Next Release +1" to "SasView 5.0.0"

@sasview-bot
Copy link
Author

Trac update at 2018/09/08 14:43:10: LauraamForster commented:

Graph number title of plot etc needs to relate to fit page number.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/25 08:39:14: smk78 commented:

Copied from duplicate #1217:
I was just helping a student who had about a dozen fit pages active in his !SasView session and therefore a multitude of graphs, which he glibly minimised…

Once you do this, there is presently no easy way to find a particular graph again. You have to maximise each icon in turn.

It would be great if you could go to the Menu Bar, select Window, and where it presently says Graph1, Graph2, etc, it also said which Graph was associated with which !FitPage.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/25 08:40:33: smk78 commented:

Copied from duplicate #1217:
Would be very nice if plots from FitPage1 were labelled graph1.1, 1.2 etc or 1a, 1b etc
Will add this to ESS kanban board for 5.0 (@richardh)

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/25 08:41:29: smk78 commented:

Copied from duplicate #1217:
Actually, Laura was looking at this during code camp. It turns out that this is better than Ingo's ticket #246…. it is ….wait for it … ticket #242 :-) I would recommend putting these specific suggestions for relating the graphs to the fitpage into that ticket and then closing this as duplicate. I do not know what Laura may have done with respect to posting to kanban boards. (@Butler)

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/25 08:43:06:

  • smk78 changed priority from "major" to "critical"
  • smk78 changed workpackage from "Plotting/Graphing Enhancements" to "SasView GUI Enhancements"

@rozyczko
Copy link
Member

Trac update at 2018/11/23 14:54:27: piotr commented:

Clicking on "Show Plot" will re-display all plots related to this particular fit page.
Is this what this ticket is asking about?

@butlerpd
Copy link
Member

Trac update at 2018/11/27 00:57:54: butler commented:

This certainly could help. There is still the issue of looking at a plot and wondering what fitpage, if any (some come from a "newplot" command). This could also be done in such a way as to answer the issue about the window menu and figuring out which graph window is which.

This could perhaps be moved to 5.1?

@butlerpd
Copy link
Member

Trac update at 2018/11/27 14:52:11: butler commented:

if showplot unminizes and brings to front all related plots that would handle the major use case. May still want to have better naming for window menu but could be pushed to a later version.

@butlerpd
Copy link
Member

Trac update at 2018/11/27 14:53:55: butler commented:

But ... needs to be on all perspectives for this to really work I guess?

@rozyczko
Copy link
Member

Trac update at 2018/11/29 13:05:29: piotr commented:

Un-minize and apply to other perspectives tracked in https://jira.esss.lu.se/browse/SASVIEW-1221

@rozyczko
Copy link
Member

Trac update at 2019/03/28 18:04:50: piotr commented:

.. which is now fixed and reviewed internally.

@rozyczko
Copy link
Member

It would be nice to see which fitpage/data set the current plot is displaying by e.g. highlighting it or bolding out its name in the data explorer.
This can be done in 5.1

@rozyczko rozyczko modified the milestones: SasView 5.0.0, SasView 5.1.0 May 15, 2019
@lucas-wilkins lucas-wilkins added the Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable. label Jul 22, 2022
@lucas-wilkins
Copy link
Contributor

I think there are more recent issues that address this fundamental issue, close?

@butlerpd
Copy link
Member

Happy to close in favor of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Enhancement Feature requests and/or general improvements Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable.
Projects
None yet
Development

No branches or pull requests

6 participants