Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize SasView[v] name in CI #2704

Open
krzywon opened this issue Jan 12, 2024 · 0 comments
Open

Generalize SasView[v] name in CI #2704

krzywon opened this issue Jan 12, 2024 · 0 comments
Labels
Enhancement Feature requests and/or general improvements Infrastructure GitHub, project structure, community etc

Comments

@krzywon
Copy link
Contributor

krzywon commented Jan 12, 2024

Is your feature request related to a problem? Please describe.
In ci.yml, the final sasview release name is hard-coded as sasviewX where X is the major release number. This was noted in #2700 and will be an issue when we eventually move from v6 to v7 (and beyond).

Describe the solution you'd like
The version number can be captured programmatically, so we should generate the name in .github/workflows/matrix.py so it is available for the workflows. This will also give us more flexibility in the release naming scheme.

Describe alternatives you've considered
Any automated way to handle this would be better than combing through the CI to increment a number every time we have a major release.

@krzywon krzywon added Enhancement Feature requests and/or general improvements Infrastructure GitHub, project structure, community etc labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Infrastructure GitHub, project structure, community etc
Projects
None yet
Development

No branches or pull requests

1 participant