Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Box Averaging in Qx (Trac #210) #358

Closed
butlerpd opened this issue Mar 30, 2019 · 2 comments
Closed

Problem with Box Averaging in Qx (Trac #210) #358

butlerpd opened this issue Mar 30, 2019 · 2 comments
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

Alexander Grutter of NIST reports "I’ve been having issues with the binning when using the “Box Averaging in Qx” function. When interacting with a 2D plot and attempting to average a rectangular box, the number of points output does not seem to correspond to the number of requested bins. For example, if I select “edit slicer parameters” and ask for 64 bins, I will get some random number of points between 100-130. Upon trying to return to the default number of bins, nothing will happen. If I then request something simple such as 1-2 bins, I get something like 5-6 points. None of this happens when using the ““Box Averaging in Qy” function.

This issue is produced on both v2.2.1 and the latest development version available online."

I have verified this is the case also with the 2D data in the test folder. Once fixed Alex should be notified (at [email protected]) as part of the resolution to this ticket.

Migrated from http://trac.sasview.org/ticket/210

{
    "status": "closed",
    "changetime": "2014-03-31T11:15:19",
    "_ts": "2014-03-31 11:15:19.172913+00:00",
    "description": "Alexander Grutter of NIST reports \"I\u2019ve been having issues with the binning when using the \u201cBox Averaging in Qx\u201d function. When interacting with a 2D plot and attempting to average a rectangular box, the number of points output does not seem to correspond to the number of requested bins. For example, if I select \u201cedit slicer parameters\u201d and ask for 64 bins, I will get some random number of points between 100-130. Upon trying to return to the default number of bins, nothing will happen. If I then request something simple such as 1-2 bins, I get something like 5-6 points. None of this happens when using the \u201c\u201cBox Averaging in Qy\u201d function.\n \nThis issue is produced on both v2.2.1 and the latest development version available online.\"\n\nI have verified this is the case also with the 2D data in the test folder.  Once fixed Alex should be notified (at [email protected]) as part of the resolution to this ticket.\n\n",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "time": "2014-03-27T22:49:14",
    "component": "SasView",
    "summary": "Problem with Box Averaging in Qx",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 3.0.0",
    "owner": "krzywon",
    "type": "defect"
}
@butlerpd butlerpd added this to the SasView 3.0.0 milestone Mar 30, 2019
@butlerpd butlerpd added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@sasview-bot
Copy link

Trac update at 2014/03/31 09:45:32:

  • krzywon changed owner from "" to "krzywon"
  • krzywon changed status from "new" to "accepted"

@sasview-bot
Copy link

Trac update at 2014/03/31 11:15:19:

  • krzywon commented:

The directionality of the averaging was not passed forward when the averaging parameters were changed, causing this issue. The default averaging direction was in the Y direction, so any averaging done once the box was set was in the Y direction. I added a class variable called direction to the BoxInteraction class that is set the first time the box averaging is called.

After testing with an anisotropic data set, the Qx and Qy averages are different and can be modified separately.

  • krzywon changed resolution from "" to "fixed"
  • krzywon changed status from "accepted" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants