Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide reader for canSAS 2d (hdf5) format (Trac #237) #385

Closed
sasview-bot opened this issue Mar 30, 2019 · 16 comments
Closed

provide reader for canSAS 2d (hdf5) format (Trac #237) #385

sasview-bot opened this issue Mar 30, 2019 · 16 comments
Assignees
Labels
Critical High priority Enhancement Feature requests and/or general improvements
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

Migrated from http://trac.sasview.org/ticket/237

{
    "status": "closed",
    "changetime": "2016-08-05T17:29:08",
    "_ts": "2016-08-05 17:29:08.560286+00:00",
    "description": "",
    "reporter": "Tobias Richter",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Framework Enhancements",
    "time": "2014-04-04T16:42:11",
    "component": "SasView",
    "summary": "provide reader for canSAS 2d (hdf5) format",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "krzywon",
    "type": "enhancement"
}
@sasview-bot sasview-bot added this to the SasView 4.0.0 milestone Mar 30, 2019
@sasview-bot sasview-bot added Critical High priority Enhancement Feature requests and/or general improvements Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2015/01/30 02:24:02: butler changed workpackage from "" to "SasView Framework Enhancements"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/02/28 11:16:36:

  • ajj changed milestone from "SasView Next Release +1" to "SasView 4.0.0"
  • ajj changed owner from "" to "krzywon"
  • ajj changed priority from "major" to "critical"
  • ajj changed status from "new" to "assigned"

@sasview-bot
Copy link
Author

Trac update at 2016/03/08 20:48:04: krzywon commented:

A file specification and sample data set would be useful for this. Could someone upload or link to either/both prior to CodeCamp IV?

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/03/09 15:28:45: smk78 commented:

See http://cansas-org.github.io/canSAS2012/

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/03/09 15:31:25: smk78 commented:

I don't know what the current status of NXcansas is. PeteJ and Tobias are probably best-placed to comment, though Andrew may know?

However, is any application actually generating files in this format at present? I'm not aware of any that are.

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/03/11 21:02:19: ajj commented:

Example datasets here:

https://github.com/canSAS-org/canSAS2012/tree/master/examples/contributions

Use the ones at the top level there - they are converted NG3 magnetic field series

NXCansas is basically done but I struggle with the nexus repo. Tobias is going to send round something later this month.

@sasview-bot
Copy link
Author

Trac update at 2016/06/20 17:44:17: krzywon commented:

I have a reader that can load both 1D and 2D data sets, but only if they are in independent 'SASentry's. All SASdata objects are lumped into a single Data1D or Data2D object. I am already working on allowing for both 1D and 2D data within the same SASentry and should have that ready prior to the final 4.0 release.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/06/20 17:56:32: smk78 commented:

The 'version 0' hdf cansas file I circulated the other month provoked quite a lot of discussion in the Data Format WG and generated several tweaks to the output. These are currently being worked into Mantid. I'll put out a revised file for testing when available.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/07/11 12:31:59: smk78 commented:

The CanSAS Data Format Working Group has now 'approved' the latest version of the NXcanSAS hdf format. Examples of 1D and 2D files have been posted to https://github.com/canSAS-org/NXcanSAS_examples/tree/master/Mantid. They are the *_v3.h5 files. We should now support this format in !SasView.

@sasview-bot
Copy link
Author

Trac update at 2016/07/13 17:38:30: krzywon commented:

My latest push can read in the v3 files in 1D and 2D format. I kept a few vestiges for the previous version to be sure there is backward compatibility with any existing data sets floating around.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/07/22 15:04:27: smk78 commented:

Seems to work. Am closing the ticket.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/07/22 15:04:35:

  • smk78 changed resolution from "" to "fixed"
  • smk78 changed status from "assigned" to "closed"

@sasview-bot
Copy link
Author

Trac update at 2016/07/22 16:40:47:

  • krzywon commented:

I'm glad to hear the reader works! I'm reopening this ticket as a reminder to myself to write unit tests.

  • krzywon changed resolution from "fixed" to ""
  • krzywon changed status from "closed" to "reopened"

@sasview-bot
Copy link
Author

Trac update at 2016/08/05 12:11:49:

  • krzywon commented:

I refactored the Cansas HDF5 reader to allow any number of SASdata with a single SASentry and and number of SASentry within a single data file. Each SASdata object becomes its own Data1D/2D object and the reader allows for 1D and 2D data within the same SASentry.

I added two unit tests that can load in a data set with a single SASdata in a single SASentry and another that loads multiple of each.

  • krzywon changed resolution from "" to "fixed"
  • krzywon changed status from "reopened" to "closed"

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2016/08/05 17:06:16: smk78 commented:

Will you be doing the same for Cansas 1D XML files with multiple SASentry and SASdata?

@sasview-bot
Copy link
Author

Trac update at 2016/08/05 17:29:08: krzywon commented:

I'm working on it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Enhancement Feature requests and/or general improvements
Projects
None yet
Development

No branches or pull requests

5 participants