Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with multishell model - glitches at high Q (Trac #288) #425

Closed
ajj opened this issue Mar 30, 2019 · 7 comments
Closed

Problem with multishell model - glitches at high Q (Trac #288) #425

ajj opened this issue Mar 30, 2019 · 7 comments
Assignees
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

The multishell model has artifacts that appear when the dimension of the core is greater than some value (depends on Q range whether the artefacts are within the range).

Same problem appears in IGOR, so it is an underlying model issue. Suspect a problem with either integration or bessel function precision.

This needs fixing ASAP

Migrated from http://trac.sasview.org/ticket/288

{
    "status": "closed",
    "changetime": "2016-10-07T00:09:25",
    "_ts": "2016-10-07 00:09:25.546237+00:00",
    "description": "The multishell model has artifacts that appear when the dimension of the core is greater than some value (depends on Q range whether the artefacts are within the range).\n\nSame problem appears in IGOR, so it is an underlying model issue. Suspect a problem with either integration or bessel function precision.\n\nThis needs fixing ASAP",
    "reporter": "ajj",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2015-01-12T07:55:50",
    "component": "SasView",
    "summary": "Problem with multishell model - glitches at high Q",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "ajj",
    "type": "defect"
}
@ajj ajj added this to the SasView 4.1.0 milestone Mar 30, 2019
@ajj ajj self-assigned this Mar 30, 2019
@ajj ajj added Critical High priority Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2015/03/10 16:21:21:

  • butler commented:

This probably is best worked through as part of new sasmodels. Since has existed in IGOR code for a while already and will require probably a fair amount of sleuthing that we may not have the bandwidth for we won't hold up the release 3.1 to fix this

  • butler changed milestone from "SasView 3.1" to "SasView Next Release +1"

@butlerpd
Copy link
Member

Trac update at 2015/08/14 19:50:57: butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"

@ajj
Copy link
Member Author

ajj commented Mar 30, 2019

Trac update at 2016/02/28 11:20:13: ajj changed priority from "major" to "critical"

@butlerpd
Copy link
Member

Trac update at 2016/08/16 14:52:12:

  • butler commented:

once again running out of bandwidth to check this for the upcoming release 4.0 -- moving to next release

  • butler changed milestone from "SasView 4.0.0" to "SasView Next Release +1"

@pkienzle
Copy link
Contributor

Trac update at 2016/08/30 19:52:54: pkienzle commented:

This ticket needs specific parameter values to check against, as well as a description of the artefacts. Many of the models have been updated to use more accurate bessel function approximations, at least for small qr, so this may already have been fixed.

@RichardHeenan
Copy link
Contributor

Trac update at 2016/10/05 13:42:25:

  • richardh commented:

Symptom - regular glitches in I(Q) at high Q when using polydispersity in any core shell model.

FIX - users should increase number of steps NPTS and/or number of sigmas NSIGS to integrate over, in the polydispersity integral

  • richardh changed resolution from "" to "fixed"
  • richardh changed status from "new" to "closed"
  • richardh changed summary from "Problem with multishell model" to "Problem with multishell model - glitches at high Q"

@butlerpd
Copy link
Member

Trac update at 2016/10/07 00:09:25: butler changed milestone from "SasView Next Release +1" to "SasView 4.1.0"

@ajj ajj closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

4 participants