Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GIT revision number to build script (Trac #419) #553

Closed
sasview-bot opened this issue Mar 30, 2019 · 14 comments
Closed

Move GIT revision number to build script (Trac #419) #553

sasview-bot opened this issue Mar 30, 2019 · 14 comments
Assignees
Labels
Defect Bug or undesirable behaviour Minor Small job
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

The command to fetch the GIT revision number must be put into the build script for all builds. I will send the appropriate information to Torben to be changed for the next revision.

Migrated from http://trac.sasview.org/ticket/419

{
    "status": "closed",
    "changetime": "2016-10-06T15:48:51",
    "_ts": "2016-10-06 15:48:51.108054+00:00",
    "description": "The command to fetch the GIT revision number must be put into the build script for all builds. I will send the appropriate information to Torben to be changed for the next revision.",
    "reporter": "krzywon",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Framework Enhancements",
    "time": "2015-05-19T14:13:22",
    "component": "SasView",
    "summary": "Move GIT revision number to build script",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "wojciech",
    "type": "defect"
}
@butlerpd
Copy link
Member

Trac update at 2015/06/21 21:50:16: butler changed workpackage from "SasView Bug Fixing" to "SasView Framework Enhancements"

@butlerpd
Copy link
Member

Trac update at 2015/08/14 20:13:19: butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/02/28 11:27:07:

  • ajj commented:

Was the info sent to Torben?

  • ajj changed owner from "" to "trnielsen"
  • ajj changed status from "new" to "assigned"

@butlerpd
Copy link
Member

Trac update at 2016/03/06 18:56:41:

  • butler commented:

Jeff should work with Torben on this as necessary -- I think he had it working locally but needed to make the change on the build machine as I recall. Also in spirit of disciplined and professional it really is time to get this done so moving it to critical list (can't call it blocker as is not really part of original core tasks we set out for this release).

  • butler changed priority from "minor" to "critical"

@sasview-bot
Copy link
Author

Trac update at 2016/03/20 10:22:31: krzywon commented:

http://stackoverflow.com/questions/5581722/how-can-i-rewrite-python-version-with-git

Here is a quick overview of how to do this during the build.

@butlerpd
Copy link
Member

Trac update at 2016/06/19 15:03:56: butler commented:

Note that we need to use

git describe --tags

as the last annotated tag was version 3.0.0 which will make the version number look wrong. Of course that means we should be annotating our release tags with a -a option on the tag. However we should also not assume that all future tags will be properly annotated and the --tags option is most appropriate anyway.

@sasview-bot
Copy link
Author

Trac update at 2016/06/30 13:49:50: trnielsen commented:

Git hash is now included in /sasview/sasview/init.py

python run.py will extract the git hash

The build scripts have been updated to include the git hash for the installers.

The git hash is the long version:
1a4f4df

The git describe --tags is not implemented:
v4.0-alpha2-30-g1a4f4df

On Mac OS git hash is only to be seen on splash screen. The "about" is missing from the help menu.

@sasview-bot
Copy link
Author

Trac update at 2016/06/30 15:38:01:

  • trnielsen changed _comment0 from:

Currently we only include git revision for sasview.

But SasView also depends upon

sasmodels
bumps
tinycc

So fra git has for sasmodels, bumps, and tiny is not included.

to:

1467301204580654

  • trnielsen commented:

Currently we only include git revision for sasview.

But sasview also depends upon

sasmodels
bumps
tinycc

So fra git hash for sasmodels, bumps, and tiny is not included.

@butlerpd
Copy link
Member

Trac update at 2016/07/02 21:13:00:

  • butler commented:

I think it would be useful to use

git describe -- tags

to pull the version number from - this command should pull the latest tagged version whether or not it was "annotated"

The current implementation is what was originally proposed and amply sufficient to understand which exact build version has the bug being reported so moving this to minor and next (+1) release.

  • butler changed milestone from "SasView 4.0.0" to "SasView Next Release +1"
  • butler changed priority from "critical" to "minor"

@butlerpd
Copy link
Member

Trac update at 2016/09/05 03:56:53:

  • butler commented:

Since we have now come around to using the original --tags We should either finish by automating the version number or decide that is not a good idea after all. Either way this ticket can then be closed.

  • butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"

@butlerpd
Copy link
Member

Trac update at 2016/09/13 13:55:27: butler changed owner from "trnielsen" to "wojciech"

@butlerpd
Copy link
Member

Trac update at 2016/09/13 14:27:25: butler changed milestone from "SasView 4.0.0" to "SasView 4.1.0"

@wpotrzebowski
Copy link
Contributor

Trac update at 2016/10/06 15:48:26: wojciech commented:

This has been solved by the commit: [https://github.com/SasView/sasview/commit/a3f1c11e89e334f2707e2834709485c8107d1e72 a3f1c11]

@wpotrzebowski
Copy link
Contributor

Trac update at 2016/10/06 15:48:51:

  • wojciech changed resolution from "" to "fixed"
  • wojciech changed status from "assigned" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Minor Small job
Projects
None yet
Development

No branches or pull requests

4 participants