-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GIT revision number to build script (Trac #419) #553
Comments
Trac update at |
Trac update at |
Trac update at
Was the info sent to Torben?
|
Trac update at
Jeff should work with Torben on this as necessary -- I think he had it working locally but needed to make the change on the build machine as I recall. Also in spirit of disciplined and professional it really is time to get this done so moving it to critical list (can't call it blocker as is not really part of original core tasks we set out for this release).
|
Trac update at http://stackoverflow.com/questions/5581722/how-can-i-rewrite-python-version-with-git Here is a quick overview of how to do this during the build. |
Trac update at Note that we need to use
as the last annotated tag was version 3.0.0 which will make the version number look wrong. Of course that means we should be annotating our release tags with a -a option on the tag. However we should also not assume that all future tags will be properly annotated and the --tags option is most appropriate anyway. |
Trac update at Git hash is now included in /sasview/sasview/init.py python run.py will extract the git hash The build scripts have been updated to include the git hash for the installers. The git hash is the long version: The git describe --tags is not implemented: On Mac OS git hash is only to be seen on splash screen. The "about" is missing from the help menu. |
Trac update at
to:
Currently we only include git revision for sasview. But sasview also depends upon sasmodels So fra git hash for sasmodels, bumps, and tiny is not included. |
Trac update at
I think it would be useful to use
to pull the version number from - this command should pull the latest tagged version whether or not it was "annotated" The current implementation is what was originally proposed and amply sufficient to understand which exact build version has the bug being reported so moving this to minor and next (+1) release.
|
Trac update at
Since we have now come around to using the original --tags We should either finish by automating the version number or decide that is not a good idea after all. Either way this ticket can then be closed.
|
Trac update at |
Trac update at |
Trac update at This has been solved by the commit: [https://github.com/SasView/sasview/commit/a3f1c11e89e334f2707e2834709485c8107d1e72 a3f1c11] |
Trac update at
|
The command to fetch the GIT revision number must be put into the build script for all builds. I will send the appropriate information to Torben to be changed for the next revision.
Migrated from http://trac.sasview.org/ticket/419
The text was updated successfully, but these errors were encountered: