Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of models in models.py and autodiscovery (Trac #506) #1319

Closed
butlerpd opened this issue Mar 30, 2019 · 3 comments
Closed

Fix loading of models in models.py and autodiscovery (Trac #506) #1319

butlerpd opened this issue Mar 30, 2019 · 3 comments
Assignees

Comments

@butlerpd
Copy link
Member

models are loaded and assigned to lists and dictionaries hard coded in models.py. All that information should now be in the models themselves. Need to replace the huge chunk of code with a loop reading all models in the models directory and getting their names (to populate a model names list for GUI dropdown) and populate the appropriate lists and dictionaries.

Migrated from http://trac.sasview.org/ticket/506

{
    "status": "closed",
    "changetime": "2016-03-18T15:57:48",
    "_ts": "2016-03-18 15:57:48.294221+00:00",
    "description": "models are loaded and assigned to lists and dictionaries hard coded in models.py.   All that information should now be in the models themselves.  Need to replace the huge chunk of code with a loop reading all models in the models directory and getting their names (to populate a model names list for GUI dropdown)  and populate the appropriate lists and dictionaries.\n",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasModels Redesign",
    "time": "2016-03-06T22:51:31",
    "component": "SasView",
    "summary": "Fix loading of models in models.py and autodiscovery",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "ajj",
    "type": "task"
}
@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/03/08 11:03:38:

  • ajj changed owner from "" to "ajj"
  • ajj changed status from "new" to "assigned"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/03/18 15:56:24:

  • ajj changed description from:

models are loaded and assigned to lists and dictionaries hard coded in models.py. All that information should now be in the models themselves. Need to replace the huge chunk of code with a loop reading all models in the models directory and getting their names (to populate a model names list for GUI dropdown) and categories and populate the appropriate lists and dictionaries.

Also check to see where autodiscover functionality should be. Can check how is done for custom models currently. Once designed a new ticket should be opened and this one closed... unless the design has the first part of this ticket too intertwined.

to:

models are loaded and assigned to lists and dictionaries hard coded in models.py. All that information should now be in the models themselves. Need to replace the huge chunk of code with a loop reading all models in the models directory and getting their names (to populate a model names list for GUI dropdown) and populate the appropriate lists and dictionaries.

  • ajj changed status from "assigned" to "accepted"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/03/18 15:57:48:

  • ajj commented:

SasView (models.py) now auto fills various lists by querying sasmodels.

New tickets created for category auto filling & custom models / user supplied models

  • ajj changed resolution from "" to "fixed"
  • ajj changed status from "accepted" to "closed"

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@ricleal ricleal transferred this issue from SasView/sasmodels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants