Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's going on with fit threads? (Trac #531) #664

Closed
rozyczko opened this issue Mar 30, 2019 · 4 comments
Closed

What's going on with fit threads? (Trac #531) #664

rozyczko opened this issue Mar 30, 2019 · 4 comments
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@rozyczko
Copy link
Member

rozyczko commented Mar 30, 2019

They are all fine until it comes to communicating with them, e.g. stopping them.
The standard mechanism is to set a control variable, pollable by the thread.
This is done here but the polling doesn't seem to happen or to be acted on.

I would like some time to investigate this.

Migrated from http://trac.sasview.org/ticket/531

{
    "status": "closed",
    "changetime": "2016-03-17T23:08:27",
    "_ts": "2016-03-17 23:08:27.113281+00:00",
    "description": "They are all fine until it comes to communicating with them, e.g. stopping them.\nThe standard mechanism is to set a control variable, pollable by the thread.\nThis is done here but the polling doesn't seem to happen or to be acted on.\n\nI would like some time to investigate this.",
    "reporter": "piotr",
    "cc": "",
    "resolution": "invalid",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-03-17T17:48:11",
    "component": "SasView",
    "summary": "What's going on with fit threads?",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "",
    "type": "defect"
}
@rozyczko rozyczko added this to the SasView 4.0.0 milestone Mar 30, 2019
@rozyczko rozyczko added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@rozyczko
Copy link
Member Author

Trac update at 2016/03/17 23:06:52: piotr commented:

Paul K to the rescue. This is working as expected - choose the right optimizer and you see things work properly.
The "proper" behaviour of threads being actively killed will happen when we switch to Qt.

Therefore - not a bug.

@rozyczko
Copy link
Member Author

Trac update at 2016/03/17 23:07:21:

  • piotr changed resolution from "" to "invalid"
  • piotr changed status from "new" to "closed"

@rozyczko
Copy link
Member Author

Trac update at 2016/03/17 23:07:47:

  • piotr changed resolution from "invalid" to ""
  • piotr changed status from "closed" to "reopened"

@rozyczko
Copy link
Member Author

Trac update at 2016/03/17 23:08:27:

  • piotr changed resolution from "" to "invalid"
  • piotr changed status from "reopened" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

1 participant