Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MutiplicationModel.py once replacement from Sasmodels is available (Trac #548) #680

Closed
ajj opened this issue Mar 30, 2019 · 5 comments
Assignees
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Once we can replace !MultiplicationModel with Product from sasmodels, we can remove !MultiplicationModel.py

Migrated from http://trac.sasview.org/ticket/548

{
    "status": "closed",
    "changetime": "2016-10-13T05:01:30",
    "_ts": "2016-10-13 05:01:30.918635+00:00",
    "description": "Once we can replace !MultiplicationModel with Product from sasmodels, we can remove !MultiplicationModel.py",
    "reporter": "ajj",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasModels Redesign",
    "time": "2016-03-21T15:22:10",
    "component": "SasView",
    "summary": "Remove MutiplicationModel.py once replacement from Sasmodels is available",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "pkienzle",
    "type": "defect"
}
@ajj ajj added this to the SasView 4.1.0 milestone Mar 30, 2019
@ajj ajj added Critical High priority Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2016/07/04 16:00:36:

  • butler changed description from "Once we can replace MultiplicationModel with Product from sasmodels, we can remove MultiplicationModel.py" to "Once we can replace !MultiplicationModel with Product from sasmodels, we can remove !MultiplicationModel.py"
  • butler changed owner from "" to "pkienzle"
  • butler changed status from "new" to "assigned"

@butlerpd
Copy link
Member

Trac update at 2016/08/16 16:46:18:

  • butler commented:

Do not have bandwidth to deal with for 4.0 which is already mega late -- can do at code camp or beyond. Leaving a high priority but moving to +1

  • butler changed milestone from "SasView 4.0.0" to "SasView Next Release +1"

@butlerpd
Copy link
Member

Trac update at 2016/09/05 02:52:45: butler changed milestone from "SasView Next Release +1" to "SasView 4.1.0"

@pkienzle
Copy link
Contributor

Trac update at 2016/10/03 21:08:32: pkienzle commented:

sasmodels/product.py implements the product model as defined in !SasView when a form factor is multiplied by a structure factor. This could be used directly from sasview.

Rather than using ProductKernel, we could somehow make ER and VR into derived parameters that can be used in constraint expressions, and use constrained fitting to on a mixture model (sasmodels/mixture.py), with product rather than sum used to mix the models. This will be considerably more work, and belongs in a separate ticket.

@sasview-bot
Copy link

Trac update at 2016/10/13 05:01:30:

In changeset 313c5c9:

#!CommitTicketReference repository="sasview" revision="313c5c92691602529afcffa8e76988a7cf6397b9"
use product model from sasmodels rather than sasview. Fixes #680, #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

4 participants