Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple array dispersity parameters (Trac #670) #265

Open
pkienzle opened this issue Mar 30, 2019 · 2 comments
Open

allow multiple array dispersity parameters (Trac #670) #265

pkienzle opened this issue Mar 30, 2019 · 2 comments

Comments

@pkienzle
Copy link
Contributor

The current implementation of fitpage (sasview 4.0) keeps a single values and weights vector that is shared by all array dispersion parameters. This means only one parameter can have array polydispersity.

Rather than keeping polydispersity information in the !FitPage attributes, query and update it directly from the sasview_model. That way the model distribution parameter can maintain separate array distributions for each parameter.

!PageState and the XML representation will need to be updated so that each distribution can have its own parameters. You may also want to rearrange the hierarchy so that the parameter contains the distribution rather than associating parameter and distribution through parameter name.

Migrated from http://trac.sasview.org/ticket/670

{
    "status": "new",
    "changetime": "2016-10-11T17:02:28",
    "_ts": "2016-10-11 17:02:28.855925+00:00",
    "description": "The current implementation of fitpage (sasview 4.0) keeps a single values and weights vector that is shared by all array dispersion parameters.   This means only one parameter can have array polydispersity.\n\nRather than keeping polydispersity information in the !FitPage attributes, query and update it directly from the sasview_model.  That way the model distribution parameter can maintain separate array distributions for each parameter.\n\n!PageState and the XML representation will need to be updated so that each distribution can have its own parameters.  You may also want to rearrange the hierarchy so that the parameter contains the distribution rather than associating parameter and distribution through parameter name.\n\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-09-28T13:16:34",
    "component": "SasView",
    "summary": "allow multiple array dispersity parameters",
    "priority": "major",
    "keywords": "",
    "milestone": "sasmodels Next Release +1",
    "owner": "",
    "type": "defect"
}
@butlerpd
Copy link
Member

Trac update at 2016/10/11 17:02:28:

  • butler commented:

This would indeed be a good code cleanup/refactor task but not likely to be done in time for 4.1 to be released so moving to next +1 for now

  • butler changed milestone from "SasView 4.1.0" to "sasmodels Next Release +1"

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@butlerpd butlerpd added this to the To Discuss milestone May 2, 2021
@butlerpd
Copy link
Member

butlerpd commented May 2, 2021

@pkienzle is this a sasmodels or sasview issue? Also is it still relevant with the Qt GUI? Given there is quite a bit of work and growing interest in the array distribution maybe we should close this ticket as obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants