Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate core shell bicelle model (Trac #696) #824

Closed
RichardHeenan opened this issue Mar 30, 2019 · 7 comments
Closed

Investigate core shell bicelle model (Trac #696) #824

RichardHeenan opened this issue Mar 30, 2019 · 7 comments
Assignees
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone

Comments

@RichardHeenan
Copy link
Contributor

RichardHeenan commented Mar 30, 2019

Looking at the c kernel code, I suspect that L in the model is actually the half length of the core, NOT the full length.

The equation in the description is not what is actually calculated.

I am not convinced yet that results are correct if sld of face is different to sld of rim.

The manual needs a diagram for the geometry of the bicelle. (The part with sld_face has radius Rcore)

Migrated from http://trac.sasview.org/ticket/696

{
    "status": "closed",
    "changetime": "2016-10-08T18:57:05",
    "_ts": "2016-10-08 18:57:05.723911+00:00",
    "description": "Looking at the c kernel code, I suspect that L in the model is actually the half length of the core, NOT the full length.\n\nThe equation in the description is not what is actually calculated.\n\nI am not convinced yet that results are correct if sld of face is different to sld of rim.\n\nThe manual needs a diagram for the geometry of the bicelle. (The part with sld_face has radius Rcore)",
    "reporter": "richardh",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-05T15:31:28",
    "component": "SasView",
    "summary": "Investigate core shell bicelle model",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "butler",
    "type": "defect"
}
@RichardHeenan RichardHeenan added this to the SasView 4.1.0 milestone Mar 30, 2019
@RichardHeenan RichardHeenan added Critical High priority Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@RichardHeenan
Copy link
Contributor Author

Trac update at 2016/10/05 15:54:14: richardh commented:

The Length is OK (of course), as it got halved elsewhere.

@RichardHeenan
Copy link
Contributor Author

Trac update at 2016/10/05 17:47:02: richardh commented:

The limiting cases of:

(a) SLDface = SLDrim does generate a core/shell cylinder as expected.

(b) SLDcore=SLDface=SLDsolvent does generate a hollow cylinder (i.e. tube or pipe), as expected.

(c) SLDrim=SLDsolvent=SLDcore ought to generate two discs with a gap of L between them, I don't think this happens, suspect some horrible cross terms are missing.

@butlerpd
Copy link
Member

Trac update at 2016/10/06 11:06:30: butler commented:

regarding the graphic -- the current graphic is taken from an RSC journal articles. While it is cited question is whether this constitutes "fair use" or would be a copyright infringement?

@RichardHeenan
Copy link
Contributor Author

Trac update at 2016/10/06 16:44:49: richardh commented:

Generated new graphics.

I(Q) equations look OK in code, need to check docs page now.

@RichardHeenan
Copy link
Contributor Author

Trac update at 2016/10/06 17:55:07:

  • richardh commented:

Have generated two new images from scratch.

Edited equation in "description" box.

Starting parameters look a little odd? - hand over to Paul

  • richardh changed owner from "richardh" to "butler"
  • richardh changed status from "new" to "assigned"

@butlerpd
Copy link
Member

Trac update at 2016/10/06 22:12:39: butler commented:

In changeset adc753dbe4450955415a1427496ad3341a93896e:

#!CommitTicketReference repository="sasmodels" revision="adc753dbe4450955415a1427496ad3341a93896e"
bicelle model documentation standardized, ref to original derivation and
equations added to rst documentation. re #824 and http://trac.sasview.org/ticket/646

@RichardHeenan
Copy link
Contributor Author

Trac update at 2016/10/08 18:57:05:

  • richardh changed resolution from "" to "fixed"
  • richardh changed status from "assigned" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

2 participants