Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize 1D and 2D data (Trac #719) #841

Open
sasview-bot opened this issue Mar 30, 2019 · 6 comments
Open

Generalize 1D and 2D data (Trac #719) #841

sasview-bot opened this issue Mar 30, 2019 · 6 comments
Labels
Cross Package Issue This issue involves a package other than SasView/sasview Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

Currently, 1D data is specifically x->q and y->Iq, but it need not be.
the data types should be made as general as possible, so that new 1D data formats can be added in more easily.
This is most directly applicable to SESANS integration, but also for future flexibility of Sasview.

Migrated from http://trac.sasview.org/ticket/719

{
    "status": "new",
    "changetime": "2017-10-27T17:33:33",
    "_ts": "2017-10-27 17:33:33.714602+00:00",
    "description": "Currently, 1D data is specifically x->q and y->Iq, but it need not be.\nthe data types should be made as general as possible, so that new 1D data formats can be added in more easily. \nThis is most directly  applicable to SESANS integration, but also for future flexibility of Sasview.",
    "reporter": "jhbakker",
    "cc": "",
    "resolution": "",
    "workpackage": "SESANS Integration",
    "time": "2016-10-07T01:16:43",
    "component": "SasView",
    "summary": "Generalize 1D and 2D data",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "",
    "type": "enhancement"
}
@sasview-bot sasview-bot added this to the SasView 4.3.0 milestone Mar 30, 2019
@sasview-bot sasview-bot added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour SESANS SESANS functionality and removed Incomplete Migration labels Mar 30, 2019
@ricleal
Copy link
Contributor

ricleal commented Mar 30, 2019

Trac update at 2016/10/09 17:10:56: ricardo commented:

Xarray (http://xarray.pydata.org/) being labelled arrays with metadata might be a viable option.
See example here: https://github.com/ricleal/PythonCode/blob/master/Xarray/Xarray%20tests.ipynb

@butlerpd
Copy link
Member

Trac update at 2016/10/13 02:14:55:

  • butler commented:

Jurrian says this is partly done but more work is required if this is to really be achieved. Moving this to 4.2 rather than closing at this point.

  • butler changed milestone from "SasView 4.1.0" to "SasView 4.2.0"

@butlerpd
Copy link
Member

Trac update at 2017/10/27 17:33:33: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

@butlerpd butlerpd modified the milestones: SasView 4.3.0, SasView WishList Apr 26, 2020
@butlerpd
Copy link
Member

@krzywon. Can you comment on this? should we close this in favor of other issues that cover similar ground (such as your universal units project)? etc or should we leave this open under wishlist for doing things like incorporating DLS fitting (and/or NSE) which would be g1r or I(Qt) vs tau?
Will move to wishlist for now.

@krzywon
Copy link
Contributor

krzywon commented Apr 27, 2020

The goal of this ticket is to incorporate 1D and 2D data into a single class that replaces the Data1D and Data2D classes. This would require many changes to how data is handled and treated not only in sascalc, but in the gui as well. Wish list is the right place for this for now.

@smk78
Copy link
Contributor

smk78 commented Sep 17, 2020

@wimbouwman comments

I don’t expect in the near future any 2D data.

@krzywon krzywon added Cross Package Issue This issue involves a package other than SasView/sasview and removed SasData - Add Ticket labels Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Package Issue This issue involves a package other than SasView/sasview Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour SESANS SESANS functionality
Projects
None yet
Development

No branches or pull requests

6 participants