Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Report Results (Trac #737) #853

Closed
smk78 opened this issue Mar 30, 2019 · 2 comments
Closed

Fix Report Results (Trac #737) #853

smk78 opened this issue Mar 30, 2019 · 2 comments
Assignees
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Report Results has stopped working in 4.1 (works in 4.0).

Traceback (most recent call last):
File "C:\Code\sasview4\src\sas\sasgui\guiframe\gui_manager.py", line 2842, in on_preview_panel
if self.cpanel_on_focus is not None:
File "C:\Code\sasview4\src\sas\sasgui\perspectives\fitting\basepage.py", line 627, in on_preview
self.state.report(images, canvases)
File "C:\Code\sasview4\src\sas\sasgui\perspectives\fitting\pagestate.py", line 591, in report
html_str, text_str, title = self.set_report_string()
File "C:\Code\sasview4\src\sas\sasgui\perspectives\fitting\pagestate.py", line 530, in set_report_string
model_name = CENTRE % modelname
NameError: global name 'CENTRE' is not defined

Migrated from http://trac.sasview.org/ticket/737

{
    "status": "closed",
    "changetime": "2016-10-09T15:39:01",
    "_ts": "2016-10-09 15:39:01.321410+00:00",
    "description": "Report Results has stopped working in 4.1 (works in 4.0).\n\nTraceback (most recent call last):\n  File \"C:\\Code\\sasview4\\src\\sas\\sasgui\\guiframe\\gui_manager.py\", line 2842, in on_preview_panel\n    if self.cpanel_on_focus is not None:\n  File \"C:\\Code\\sasview4\\src\\sas\\sasgui\\perspectives\\fitting\\basepage.py\", line 627, in on_preview\n    self.state.report(images, canvases)\n  File \"C:\\Code\\sasview4\\src\\sas\\sasgui\\perspectives\\fitting\\pagestate.py\", line 591, in report\n    html_str, text_str, title = self.set_report_string()\n  File \"C:\\Code\\sasview4\\src\\sas\\sasgui\\perspectives\\fitting\\pagestate.py\", line 530, in set_report_string\n    model_name = CENTRE % modelname\nNameError: global name 'CENTRE' is not defined",
    "reporter": "smk78",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-08T17:17:29",
    "component": "SasView",
    "summary": "Fix Report Results",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "krzywon",
    "type": "defect"
}
@smk78 smk78 added this to the SasView 4.1.0 milestone Mar 30, 2019
@smk78 smk78 added Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@mdoucet
Copy link
Contributor

mdoucet commented Mar 30, 2019

Trac update at 2016/10/09 15:15:29:

  • mathieu changed owner from "mathieu" to "krzywon"
  • mathieu changed status from "new" to "assigned"

@sasview-bot
Copy link

Trac update at 2016/10/09 15:39:01:

  • krzywon commented:

In changeset 467202f:

#!CommitTicketReference repository="sasview" revision="467202f2479da030154e3d3657b1bf2642b5b503"
Fixes #853: Report results edit option working again.
  • krzywon changed resolution from "" to "fixed"
  • krzywon changed status from "assigned" to "closed"

@smk78 smk78 closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

4 participants