Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old-style custom models don't load (Trac #744) #860

Closed
wpotrzebowski opened this issue Mar 30, 2019 · 2 comments
Closed

Old-style custom models don't load (Trac #744) #860

wpotrzebowski opened this issue Mar 30, 2019 · 2 comments
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@wpotrzebowski
Copy link
Contributor

wpotrzebowski commented Mar 30, 2019

Old style python custom model don't load. It was fixed before but apparently the issue reoccurred. It doesn't work either on windows or mac (regardless opencl or not).

Traceback (most recent call last):
File "C:\Users\wojtek\SASVIEW_WORKSPACE\sasview\src\sas\sasgui\perspectives\fitting\fitpage.py", line 1179, in _on_select_model
self._on_select_model_helper()
File "C:\Users\wojtek\SASVIEW_WORKSPACE\sasview\src\sas\sasgui\perspectives\fitting\basepage.py", line 1955, in _on_select_model_helper
if form_factor is None or not form_factor.is_form_factor:

AttributeError: class Model has no attribute 'is_form_factor'

Migrated from http://trac.sasview.org/ticket/744

{
    "status": "closed",
    "changetime": "2016-10-09T15:16:02",
    "_ts": "2016-10-09 15:16:02.627269+00:00",
    "description": "Old style python custom model don't load. It was fixed before but apparently the issue reoccurred. It doesn't work either on windows or mac (regardless opencl or not).\n\nTraceback (most recent call last):\n  File \"C:\\Users\\wojtek\\SASVIEW_WORKSPACE\\sasview\\src\\sas\\sasgui\\perspectives\\fitting\\fitpage.py\", line 1179, in _on_select_model\n    self._on_select_model_helper()\n  File \"C:\\Users\\wojtek\\SASVIEW_WORKSPACE\\sasview\\src\\sas\\sasgui\\perspectives\\fitting\\basepage.py\", line 1955, in _on_select_model_helper\n    if form_factor is None or not form_factor.is_form_factor:\n\nAttributeError: class Model has no attribute 'is_form_factor'",
    "reporter": "wojciech",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-09T14:57:35",
    "component": "SasView",
    "summary": "Old-style custom models don't load",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "",
    "type": "defect"
}
@wpotrzebowski wpotrzebowski added this to the SasView 4.1.0 milestone Mar 30, 2019
@wpotrzebowski wpotrzebowski added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@wpotrzebowski
Copy link
Contributor Author

Trac update at 2016/10/09 15:15:56: wojciech commented:

Solved by Matthieu in commit [https://github.com/SasView/sasmodels/commit/ed10b575284d50e5f99b3b93b89f0ec5edb5a6d5 ed10b575284d50e5f99b3b93b89f0ec5edb5a6d5]

@wpotrzebowski
Copy link
Contributor Author

Trac update at 2016/10/09 15:16:02:

  • wojciech changed resolution from "" to "fixed"
  • wojciech changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

1 participant