Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enhanced fitting constraints (Trac #746) #862

Closed
RichardHeenan opened this issue Mar 30, 2019 · 3 comments
Closed

Consider enhanced fitting constraints (Trac #746) #862

RichardHeenan opened this issue Mar 30, 2019 · 3 comments
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour

Comments

@RichardHeenan
Copy link
Contributor

RichardHeenan commented Mar 30, 2019

It would be useful to add a fittable parameter that can be used within constraints. Eg Imagine I want (Rcore+Tshell)/Rcore = C, this requires the constraint for Tshell = Rcore(C-1) where C can be fitted. Implementing this would save having to write variant models, BUT the constraints may need to be called inside polydispersity/integrations for say Rcore which may not be possible in !SasView?

(FISH permitted this)

Migrated from http://trac.sasview.org/ticket/746

{
    "status": "closed",
    "changetime": "2018-07-03T16:49:25",
    "_ts": "2018-07-03 16:49:25.166295+00:00",
    "description": "It would be useful to add a fittable parameter that can be used within constraints. Eg Imagine I want (Rcore+Tshell)/Rcore = C, this requires the constraint for Tshell = Rcore(C-1) where C can be fitted. Implementing this would save having to write variant models, BUT the constraints may need to be called inside polydispersity/integrations for say Rcore which may not be possible in !SasView?\n\n(FISH permitted this)",
    "reporter": "richardh",
    "cc": "",
    "resolution": "wontfix",
    "workpackage": "Beta Approximation Project",
    "time": "2016-10-09T15:54:23",
    "component": "SasView",
    "summary": "Consider enhanced fitting constraints",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "",
    "type": "enhancement"
}
@RichardHeenan RichardHeenan added this to the SasView Next Release +1 milestone Mar 30, 2019
@RichardHeenan RichardHeenan added Beta Approximation Project Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@pkienzle
Copy link
Contributor

Trac update at 2016/10/10 15:54:27: pkienzle commented:

I wasn't able to support dependent parameters within the kernel without slowing down the unconstrained kernels.

How many variant kernels are there going to be in practice? Do you have a large set of saved FISH fits? Can we search for those which use constraints in this way?

If the number of models with reasonable variants is small, then we can handle those individually using the style of the RPA model, with a dropdown list to select the variant and a hidden() function to return the list of inactive parameters for each variant.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/07/03 13:23:18:

  • smk78 commented:

Moving to the Beta Approximation Work Package whilst we consider enhancing constraints.

  • smk78 changed workpackage from "SasView Fitting Redesign" to "Beta Approximation Project"

@RichardHeenan
Copy link
Contributor Author

Trac update at 2018/07/03 16:49:25:

  • richardh commented:

Though I wrote the ticket I am going to close it, as introducing a fitable parameter on the fly is beyond even what is being suggested in #888, #1160 etc. Users will simply have to create a plugin model with suitable parameters.

  • richardh changed resolution from "" to "wontfix"
  • richardh changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants