Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute button no longer seems to work (Trac #753) #869

Closed
butlerpd opened this issue Mar 30, 2019 · 6 comments
Closed

compute button no longer seems to work (Trac #753) #869

butlerpd opened this issue Mar 30, 2019 · 6 comments
Assignees
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

after closing #823 it seems that something along the way has broken that button completely - basically it no longer seems to do anything regardless of being theory or a fit page with data. Does seem that in 2D it may be working.

Migrated from http://trac.sasview.org/ticket/753

{
    "status": "closed",
    "changetime": "2016-12-19T18:52:37",
    "_ts": "2016-12-19 18:52:37.874089+00:00",
    "description": "after closing #694 it seems that something along the way has broken that button completely - basically it no longer seems to do anything regardless of being theory or a fit page with data.  Does seem that in 2D it may be working.",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-10T14:10:35",
    "component": "SasView",
    "summary": "compute button no longer seems to work",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "ajj",
    "type": "defect"
}
@butlerpd butlerpd added this to the SasView 4.1.0 milestone Mar 30, 2019
@butlerpd butlerpd added Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour Incomplete Migration labels Mar 30, 2019
@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/10/10 20:01:16:

  • ajj commented:

In changeset 8662a58:

#!CommitTicketReference repository="sasview" revision="8662a587350e2b5ad37342ca1d19a5aeb0e7fe8c"
Updating basepage and fitpage to pass is_modified flag out of helper functions so that _onDraw can correctly determine that there is a change and recalculate/redraw

Fixes #869 compute button no longer seems to work
  • ajj changed resolution from "" to "fixed"
  • ajj changed status from "new" to "closed"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2016/10/10 20:48:06: ajj commented:

In changeset 3bec50a:

#!CommitTicketReference repository="sasview" revision="3bec50ae2f0e34d160b7c5524ce22736baa10388"
Really fixes #869 (proper call to !wx.CallAfter that works outside if a debugger)

@butlerpd
Copy link
Member Author

Trac update at 2016/10/10 20:48:06: butler changed _comment0 from:

In [changeset:"3bec50ae2f0e34d160b7c5524ce22736baa10388/sasview"]:
{{{
#!CommitTicketReference repository="sasview" revision="3bec50ae2f0e34d160b7c5524ce22736baa10388"
Really fixes #753 (proper call to wx.CallAfter that works outside if a debugger)
}}}

to:

1477583411024622

@pkienzle
Copy link
Contributor

Trac update at 2016/10/13 05:11:48:

  • pkienzle commented:

Select a model, change Npts to 500 and click "Compute". On the mac nothing happens. Press "Enter" in the Npts field and the theory is updated.

Toggling "Log?" does not trigger a recompute (good), but the after toggling "Log?" the compute button doesn't change anything.

Compute does recognize a change in a parameter value and update accordingly.

  • pkienzle changed resolution from "fixed" to ""
  • pkienzle changed status from "closed" to "reopened"

@sasview-bot
Copy link

Trac update at 2016/11/11 09:09:06:

In changeset 3f8c7bb:

#!CommitTicketReference repository="sasview" revision="3f8c7bb979f5ba83ed7142730b80d8a6cd21e8ca"
Enforce callbacks for the Fitting group box. Fixes #869

@sasview-bot
Copy link

Trac update at 2016/12/19 18:52:37: GitHub [email protected] commented:

In changeset 09fdc89:

#!CommitTicketReference repository="sasview" revision="09fdc89a900cc298c3aaa4cd3ef8497a23108a18"
Merge pull request #247 from SasView/ticket-753

Enforce callbacks for the Fitting group box. Fixes #869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

4 participants