Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S(q) models should not have scale and background parameters added (Trac #755) #871

Closed
ajj opened this issue Mar 30, 2019 · 1 comment
Closed
Assignees
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

In 3.1.2 structure factors did not have scale and background parameters (correctly)

In 4.x they are having them added.

structure_factor=True should be honoured and these values should not be added to the model.

Migrated from http://trac.sasview.org/ticket/755

{
    "status": "closed",
    "changetime": "2016-10-10T15:20:11",
    "_ts": "2016-10-10 15:20:11.975350+00:00",
    "description": "In 3.1.2 structure factors did not have scale and background parameters (correctly)\n\nIn 4.x they are having them added. \n\nstructure_factor=True should be honoured and these values should not be added to the model.",
    "reporter": "ajj",
    "cc": "",
    "resolution": "duplicate",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-10T14:40:35",
    "component": "SasView",
    "summary": "S(q) models should not have scale and background parameters added",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "ajj",
    "type": "defect"
}
@ajj ajj added this to the SasView 4.1.0 milestone Mar 30, 2019
@ajj ajj self-assigned this Mar 30, 2019
@ajj ajj added Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@pkienzle
Copy link
Contributor

Trac update at 2016/10/10 15:20:11:

  • pkienzle commented:

Duplicates #788

  • pkienzle changed resolution from "" to "duplicate"
  • pkienzle changed status from "new" to "closed"

@ajj ajj closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Prevents a different issue from being resolved Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

2 participants