Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting all data when a constrained fit page is open leaves only the constrained fit page left (Trac #761) #877

Closed
sasview-bot opened this issue Mar 30, 2019 · 2 comments
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@sasview-bot
Copy link

sasview-bot commented Mar 30, 2019

When a simultaneous and constrained window is open and all data are deleted from the data panel, the only fit page left open is a constrained fit window that is not drawn properly. Closing this panel before deleting all the data seems like the expected behavior to me.

This has been present since at least release v3.1.2.

Migrated from http://trac.sasview.org/ticket/761

{
    "status": "closed",
    "changetime": "2016-12-16T15:46:48",
    "_ts": "2016-12-16 15:46:48.735035+00:00",
    "description": "When a simultaneous and constrained window is open and all data are deleted from the data panel, the only fit page left open is a constrained fit window that is not drawn properly. Closing this panel before deleting all the data seems like the expected behavior to me.\n\nThis has been present since at least release v3.1.2.",
    "reporter": "krzywon",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-10T19:04:45",
    "component": "SasView",
    "summary": "Deleting all data when a constrained fit page is open leaves only the constrained fit page left",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "krzywon",
    "type": "defect"
}
@sasview-bot sasview-bot added this to the SasView 4.1.0 milestone Mar 30, 2019
@sasview-bot sasview-bot added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@sasview-bot
Copy link
Author

Trac update at 2016/12/16 15:43:42: krzywon commented:

In changeset 67b0a99:

#!CommitTicketReference repository="sasview" revision="67b0a99ce9f69a9dfef035e8e4a06588c9f1602f"
#877: Constrained fit pages are now deleted if they no longer have any data in them when other data sets are deleted. #921: Fixed a bug where dQ smearing option was unavailable for 1D data sets.

@sasview-bot
Copy link
Author

Trac update at 2016/12/16 15:46:48:

  • krzywon changed resolution from "" to "fixed"
  • krzywon changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

2 participants